feat: blob v2 descriptor read support#548
Open
geruh wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #539 and #505
Adds read support for blob v2 columns. Instead of hiding blob metadata behind virtual columns, we surface the raw descriptor struct directly to Spark like what the original issue was stating.
Querying blob metadata is just a column projection now, no byte fetch:
A column is blob v2 when any of these hold:
lance.blob.v2is set in lancelance-encoding:blob-v2 = trueSchema rewrite lives in
BlobUtils.applyBlobV2DescriptorSchema(...), called fromLanceDataset.schema(),LanceDataSource.inferSchema(), and theLanceScanBuilderconstructor.Filter pushdown
Suppressed for any table with a v2 column. The previous per-predicate gate had to be reverted because
calc_eager_projectionpanics on filters that never reference blob columns. Zonemap fragment pruning still runs. Need more investigation hereTesting
No end-to-end pylance interop tests here. The connector can't write v2 blobs yet, so producing test data requires pylance as an external dep. E2E coverage lands naturally once the write path exists, extending
BaseBlobCreateTableTest's pattern.Local verification
Wrote a v2 dataset with pylance hitting all four
BlobKindtiers (Inline, Packed, Dedicated, External) plus a null row, then read it back through Spark on this branch:write_blob_v2.py
Spark output