Commit 2409769
committed
Fix makeContext to preserve stream defaults when overriding properties
The makeContext helper was incorrectly spreading all overrides at the end,
which clobbered the carefully-constructed stdin/stdout/stderr objects with
their merged defaults. This caused tests to exercise code paths with
malformed context objects missing columns/rows, resulting in
COLUMNS=undefined and LINES=undefined being passed to docker exec.
Fixed by destructuring stream keys from overrides and only spreading
the remaining properties, ensuring per-property merging takes effect.1 parent 4d01540 commit 2409769
1 file changed
Lines changed: 13 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
33 | 36 | | |
34 | 37 | | |
35 | 38 | | |
| |||
0 commit comments