Skip to content

Commit 46d7e96

Browse files
committed
formatting
1 parent ca15be4 commit 46d7e96

6 files changed

Lines changed: 8 additions & 11 deletions

File tree

src/Illuminate/Database/Query/Builder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2648,7 +2648,7 @@ public function insert(array $values)
26482648
}
26492649

26502650
/**
2651-
* Insert ignore a new record into the database.
2651+
* Insert a new record into the database while ignoring errors.
26522652
*
26532653
* @param array $values
26542654
* @return int

src/Illuminate/Database/Query/Grammars/Grammar.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -881,7 +881,7 @@ public function compileInsert(Builder $query, array $values)
881881
*/
882882
public function compileInsertOrIgnore(Builder $query, array $values)
883883
{
884-
throw new RuntimeException('This database engine does not support insert or ignore.');
884+
throw new RuntimeException('This database engine does not support inserting while ignoring errors.');
885885
}
886886

887887
/**

src/Illuminate/Database/Query/Grammars/MySqlGrammar.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
namespace Illuminate\Database\Query\Grammars;
44

5+
use Illuminate\Support\Str;
56
use Illuminate\Database\Query\Builder;
67
use Illuminate\Database\Query\JsonExpression;
78

@@ -63,7 +64,7 @@ public function compileSelect(Builder $query)
6364
*/
6465
public function compileInsertOrIgnore(Builder $query, array $values)
6566
{
66-
return substr_replace($this->compileInsert($query, $values), ' ignore', 6, 0);
67+
return Str::replaceFirst('insert', 'insert ignore', $this->compileInsert($query, $values));
6768
}
6869

6970
/**

src/Illuminate/Database/Query/Grammars/PostgresGrammar.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -217,11 +217,7 @@ public function compileInsertOrIgnore(Builder $query, array $values)
217217
*/
218218
public function compileInsertGetId(Builder $query, $values, $sequence)
219219
{
220-
if (is_null($sequence)) {
221-
$sequence = 'id';
222-
}
223-
224-
return $this->compileInsert($query, $values).' returning '.$this->wrap($sequence);
220+
return $this->compileInsert($query, $values).' returning '.$this->wrap($sequence ?: 'id');
225221
}
226222

227223
/**

src/Illuminate/Database/Query/Grammars/SQLiteGrammar.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ public function compileInsert(Builder $query, array $values)
187187
*/
188188
public function compileInsertOrIgnore(Builder $query, array $values)
189189
{
190-
return substr_replace($this->compileInsert($query, $values), ' or ignore', 6, 0);
190+
return Str::replaceFirst('insert', 'insert or ignore', $this->compileInsert($query, $values));
191191
}
192192

193193
/**

tests/Database/DatabaseQueryBuilderTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1870,7 +1870,7 @@ function (Builder $query) {
18701870
public function testInsertOrIgnoreMethod()
18711871
{
18721872
$this->expectException(RuntimeException::class);
1873-
$this->expectExceptionMessage('This database engine does not support insert or ignore.');
1873+
$this->expectExceptionMessage('does not support');
18741874
$builder = $this->getBuilder();
18751875
$builder->from('users')->insertOrIgnore(['email' => 'foo']);
18761876
}
@@ -1902,7 +1902,7 @@ public function testSQLiteInsertOrIgnoreMethod()
19021902
public function testSqlServerInsertOrIgnoreMethod()
19031903
{
19041904
$this->expectException(RuntimeException::class);
1905-
$this->expectExceptionMessage('This database engine does not support insert or ignore.');
1905+
$this->expectExceptionMessage('does not support');
19061906
$builder = $this->getSqlServerBuilder();
19071907
$builder->from('users')->insertOrIgnore(['email' => 'foo']);
19081908
}

0 commit comments

Comments
 (0)