Merge pull request #29581 from mvmx/simplify-isset

[5.8] Simplify isset()

Author: taylorotwell

src/Illuminate/Container/Container.php

@@ -753,9 +753,7 @@ protected function getContextualConcrete($abstract)
      */
     protected function findInContextualBindings($abstract)
     {
-        if (isset($this->contextual[end($this->buildStack)][$abstract])) {
-            return $this->contextual[end($this->buildStack)][$abstract];
-        }
+        return $this->contextual[end($this->buildStack)][$abstract] ?? null;
     }
 
     /**

src/Illuminate/Database/Connectors/SqlServerConnector.php

@@ -166,11 +166,11 @@ protected function buildConnectString($driver, array $arguments)
      */
     protected function buildHostString(array $config, $separator)
     {
-        if (isset($config['port']) && ! empty($config['port'])) {
-            return $config['host'].$separator.$config['port'];
-        } else {
+        if (empty($config['port'])) {
             return $config['host'];
         }
+
+        return $config['host'].$separator.$config['port'];
     }
 
     /**

src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php

@@ -372,9 +372,7 @@ public function getAttributeValue($key)
      */
     protected function getAttributeFromArray($key)
     {
-        if (isset($this->attributes[$key])) {
-            return $this->attributes[$key];
-        }
+        return $this->attributes[$key] ?? null;
     }
 
     /**

src/Illuminate/Log/ParsesLogConfiguration.php

@@ -57,10 +57,6 @@ protected function level(array $config)
      */
     protected function parseChannel(array $config)
     {
-        if (! isset($config['name'])) {
-            return $this->getFallbackChannelName();
-        }
-
-        return $config['name'];
+        return $config['name'] ?? $this->getFallbackChannelName();
     }
 }