From 23e3486da517206833acfaca64a0ad87f5a84f07 Mon Sep 17 00:00:00 2001 From: Vedant Madane <6527493+VedantMadane@users.noreply.github.com> Date: Wed, 1 Apr 2026 04:15:59 +0000 Subject: [PATCH] fix(task): always send completed filter in +get-my-tasks When --complete is omitted, the completed query parameter was not sent to the API, causing it to return all tasks (completed + incomplete) instead of defaulting to incomplete-only as documented. Always send completed=false when the flag is unset so the behavior matches the help text. Fixes #164 --- shortcuts/task/task_get_my_tasks.go | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/shortcuts/task/task_get_my_tasks.go b/shortcuts/task/task_get_my_tasks.go index 5f738054f7..a0ff21ea5a 100644 --- a/shortcuts/task/task_get_my_tasks.go +++ b/shortcuts/task/task_get_my_tasks.go @@ -44,9 +44,7 @@ var GetMyTasks = common.Shortcut{ "user_id_type": "open_id", "page_size": 50, } - if runtime.Cmd.Flags().Changed("complete") { - params["completed"] = runtime.Bool("complete") - } + params["completed"] = runtime.Bool("complete") return d.GET("/open-apis/task/v2/tasks").Params(params) }, @@ -58,13 +56,7 @@ var GetMyTasks = common.Shortcut{ queryParams.Set("type", "my_tasks") queryParams.Set("user_id_type", "open_id") queryParams.Set("page_size", "50") - if runtime.Cmd.Flags().Changed("complete") { - if runtime.Bool("complete") { - queryParams.Set("completed", "true") - } else { - queryParams.Set("completed", "false") - } - } + queryParams.Set("completed", strconv.FormatBool(runtime.Bool("complete"))) // parse time flags to ms timestamp if provided var createdAfterMs, dueStartMs, dueEndMs int64