feat: Create an --output/-o flag for JSON or plain text responses#195
Merged
Conversation
k3llymariee
approved these changes
Apr 22, 2024
Contributor
Author
|
@k3llymariee I added another commit for output flag error handling. Could you review again? |
k3llymariee
approved these changes
Apr 22, 2024
| } | ||
| } | ||
|
|
||
| func CmdError(err error, commandPath string) error { |
Contributor
There was a problem hiding this comment.
not related to this change but in getCommandPath we have stripe hardcoded still 😅
There was a problem hiding this comment.
We should remove this reference haha
sunnyguduru
approved these changes
Apr 22, 2024
* Use output flag to show JSON or plaintext * Call outputter in command handler * Backfill test * Rename * Refactor to pass in fn instead of interface * Remove stripe code * Create additional interface * Implement plaintext for multiple resource response (#199)
This was referenced Apr 24, 2024
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
--output/-oflag to set the output of a command. We'll use this to return either JSON or plain text when an command has output.Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.