feat: show successful resource delete message#212
Merged
Conversation
dbolson
commented
Apr 25, 2024
| } | ||
|
|
||
| output, err := output.CmdOutputCreate( | ||
| output, err := output.CmdOutputCreateResource( |
Contributor
Author
There was a problem hiding this comment.
The API has one less param now.
|
|
||
| // CmdOutputCreateResource returns a response from a resource create action formatted based on the | ||
| // output flag. | ||
| func CmdOutputCreateResource(outputKind string, input []byte) (string, error) { |
Contributor
Author
There was a problem hiding this comment.
The create and update versions are very similar but delete is different.
sunnyguduru
approved these changes
Apr 29, 2024
dbolson
commented
Apr 29, 2024
Contributor
Author
dbolson
left a comment
dbolson
left a comment
There was a problem hiding this comment.
I can simplify the output function for error handling in another PR.
| response, | ||
| output.SingularPlaintextOutputFn, | ||
| ) | ||
| output, err := output.CmdOutput("get", viper.GetString(cliflags.OutputFlag), response) |
Contributor
Author
There was a problem hiding this comment.
We need to know if the plaintext output should include a success message, so we pass in this value.
| return nil, errors.NewLDAPIError(err) | ||
| } | ||
| memberJson, err := json.Marshal(members.Items) | ||
| membersJson, err := json.Marshal(members) |
Contributor
Author
There was a problem hiding this comment.
Updated this for consistency with other responses for multiple resources.
|
|
||
| // CmdOutputCreate builds a command response based on the flag the user provided and the shape of | ||
| // the input with a successfully created message. The expected shape is a single JSON object. | ||
| func CmdOutputCreate(outputKind string, input []byte, fn PlaintextOutputFn) (string, error) { |
Contributor
Author
There was a problem hiding this comment.
Removed these to have a single CmdOutput function so it's simpler for dynamic resource commands.
|
|
||
| // CmdOutputMultiple builds a command response based on the flag the user provided and the shape of | ||
| // the input. The expected shape is a list of JSON objects. | ||
| func CmdOutputMultiple(outputKind string, input []byte, fn PlaintextOutputFn) (string, error) { |
Contributor
Author
There was a problem hiding this comment.
This is now unused.
|
|
||
| // CmdOutput returns a response from a resource create action formatted based on the | ||
| // output flag along with an optional message based on the action. | ||
| func CmdOutput(action string, outputKind string, input []byte) (string, error) { |
Contributor
Author
There was a problem hiding this comment.
This is the "do all the things" function.
This was referenced Apr 29, 2024
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We needed to refactor some things to support showing a "Successfully deleted {resource}" message because we don't get a JSON response from API delete requests.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.