fix: Fix data flag JSON error handling#214
Merged
Merged
Conversation
dbolson
commented
Apr 29, 2024
| } | ||
|
|
||
| return errors.NewError(output) | ||
| return errors.NewError(output.CmdOutputError(viper.GetString(cliflags.OutputFlag), err)) |
Contributor
Author
There was a problem hiding this comment.
I used this new function here and for creating members. Another PR will add it elsewhere.
| var data []members.MemberInput | ||
| // TODO: why does viper.GetString(cliflags.DataFlag) not work? | ||
| err := json.Unmarshal([]byte(cmd.Flags().Lookup(cliflags.DataFlag).Value.String()), &data) | ||
| err := json.Unmarshal([]byte(viper.GetString(cliflags.DataFlag)), &data) |
Contributor
Author
There was a problem hiding this comment.
This seems fine now.
| } | ||
|
|
||
| return errors.NewError(output) | ||
| return errors.NewError(output.CmdOutputError(viper.GetString(cliflags.OutputFlag), err)) |
Contributor
Author
There was a problem hiding this comment.
We should probably change CmdOutput to only return a string, not a possible error.
| underlying := errs.NewAPIError( | ||
| []byte(`{"code":"conflict","message":"an error"}`), | ||
| errors.New("409 Conflict"), | ||
| errors.New("400 an error"), |
Contributor
Author
There was a problem hiding this comment.
Updated these based on the test descriptions.
|
|
||
| if outputKind == "json" { | ||
| // convert to a well-formatted output | ||
| formattedOutput, _ := json.Marshal(r) |
Contributor
Author
There was a problem hiding this comment.
The output has extra spacing if we don't do this.
k3llymariee
approved these changes
Apr 29, 2024
3 tasks
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the
members createcommand with invalid JSON would show a bad error:Now it shows a nicer one:
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.