From 1f93ffd2981355cb757853fe2188336a3324103f Mon Sep 17 00:00:00 2001
From: Danny Olson <dolson@launchdarkly.com>
Date: Mon, 15 Apr 2024 09:55:01 -0700
Subject: [PATCH 1/2] Adds support for ldcli config --set

The set flag takes a key/value pair and writes them to the config file
if they are relevant. It ignores arbitrary keys and for now only
supports:

* access-token
* base-uri
---
 cmd/config/config.go      | 81 ++++++++++++++++++++++++++++++++++++++-
 internal/config/config.go |  1 +
 2 files changed, 81 insertions(+), 1 deletion(-)

diff --git a/cmd/config/config.go b/cmd/config/config.go
index 858b7b04..14526c2f 100644
--- a/cmd/config/config.go
+++ b/cmd/config/config.go
@@ -2,6 +2,7 @@ package config
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"os"
 
@@ -54,7 +55,31 @@ func run() func(*cobra.Command, []string) error {
 
 			fmt.Fprint(cmd.OutOrStdout(), string(configJSON)+"\n")
 		case viper.GetBool(SetFlag):
-			fmt.Fprintln(cmd.OutOrStdout(), "called --set flag")
+			// flag needs two arguments: a key and value
+			if len(args)%2 != 0 {
+				return errors.New("flag needs an argument: --set")
+			}
+
+			rawConfig, v, err := getRawConfig()
+			if err != nil {
+				return err
+			}
+
+			// add arg pairs to config
+			// where each argument is --set arg1 val1 --set arg2 val2
+			for i, a := range args {
+				if i%2 == 0 {
+					rawConfig[a] = struct{}{}
+				} else {
+					rawConfig[args[i-1]] = a
+				}
+			}
+
+			setKeyFn := func(key string, value interface{}, v *viper.Viper) {
+				v.Set(key, value)
+			}
+
+			return writeConfig(config.NewConfig(rawConfig), v, setKeyFn)
 		case viper.GetBool(UnsetFlag):
 			fmt.Fprintln(cmd.OutOrStdout(), "called --unset flag")
 		}
@@ -84,6 +109,27 @@ func getConfig() (config.ConfigFile, *viper.Viper, error) {
 	return c, v, nil
 }
 
+// getRawConfig builds a map of the values in the config file.
+func getRawConfig() (map[string]interface{}, *viper.Viper, error) {
+	v, err := getViperWithConfigFile()
+	if err != nil {
+		return nil, nil, err
+	}
+
+	data, err := os.ReadFile(v.ConfigFileUsed())
+	if err != nil {
+		return nil, nil, err
+	}
+
+	config := make(map[string]interface{}, 0)
+	err = yaml.Unmarshal([]byte(data), &config)
+	if err != nil {
+		return nil, nil, err
+	}
+
+	return config, v, nil
+}
+
 // getViperWithConfigFile ensures the viper instance has a config file written to the filesystem.
 // We want to write the file when someone runs a config command.
 func getViperWithConfigFile() (*viper.Viper, error) {
@@ -105,3 +151,36 @@ func getViperWithConfigFile() (*viper.Viper, error) {
 
 	return v, nil
 }
+
+// writeConfig writes the values in config to the config file based on the filter function.
+func writeConfig(
+	conf config.ConfigFile,
+	v *viper.Viper,
+	filterFn func(key string, value interface{}, v *viper.Viper),
+) error {
+	// create a new viper instance since the existing one has the command name and flags already set,
+	// and these will get written to the config file.
+	newViper := viper.New()
+	newViper.SetConfigFile(v.ConfigFileUsed())
+
+	configYAML, err := yaml.Marshal(conf)
+	if err != nil {
+		return err
+	}
+	rawConfig := make(map[string]interface{})
+	err = yaml.Unmarshal(configYAML, &rawConfig)
+	if err != nil {
+		return err
+	}
+
+	for key, value := range rawConfig {
+		filterFn(key, value, newViper)
+	}
+
+	err = newViper.WriteConfig()
+	if err != nil {
+		return err
+	}
+
+	return nil
+}
diff --git a/internal/config/config.go b/internal/config/config.go
index f70286b2..13180881 100644
--- a/internal/config/config.go
+++ b/internal/config/config.go
@@ -43,6 +43,7 @@ func GetConfigPath() string {
 		}
 		configPath = filepath.Join(home, ".config")
 	}
+
 	return filepath.Join(configPath, "ldcli")
 }
 

From 11e5f70c12250bdecbd4ccc8153fd1f004ffee61 Mon Sep 17 00:00:00 2001
From: Danny Olson <dbolson@gmail.com>
Date: Tue, 16 Apr 2024 13:28:11 -0700
Subject: [PATCH 2/2] Add config unset flag (#178)

The unset flag takes a value removes it from the config file if
it is relevant. It ignores arbitrary keys and for now only supports:

access-token
base-uri
---
 cmd/config/config.go | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/cmd/config/config.go b/cmd/config/config.go
index 14526c2f..9ed15df3 100644
--- a/cmd/config/config.go
+++ b/cmd/config/config.go
@@ -80,8 +80,19 @@ func run() func(*cobra.Command, []string) error {
 			}
 
 			return writeConfig(config.NewConfig(rawConfig), v, setKeyFn)
-		case viper.GetBool(UnsetFlag):
-			fmt.Fprintln(cmd.OutOrStdout(), "called --unset flag")
+		case viper.IsSet(UnsetFlag):
+			config, v, err := getConfig()
+			if err != nil {
+				return err
+			}
+
+			unsetKeyFn := func(key string, value interface{}, v *viper.Viper) {
+				if key != viper.GetString("unset") {
+					v.Set(key, value)
+				}
+			}
+
+			return writeConfig(config, v, unsetKeyFn)
 		}
 
 		return nil