From b0af7fc9236b5df98d9d2bcdbf03d59d8ea4e903 Mon Sep 17 00:00:00 2001 From: Danny Olson Date: Tue, 13 Aug 2024 14:53:19 -0700 Subject: [PATCH 1/2] Remove stutter from "fetching {sdk name} SDK SDK" --- internal/quickstart/show_sdk_instructions.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/quickstart/show_sdk_instructions.go b/internal/quickstart/show_sdk_instructions.go index 5dfab305..9b2f230f 100644 --- a/internal/quickstart/show_sdk_instructions.go +++ b/internal/quickstart/show_sdk_instructions.go @@ -2,8 +2,8 @@ package quickstart import ( "fmt" - "github.com/launchdarkly/sdk-meta/api/sdkmeta" + "github.com/launchdarkly/sdk-meta/api/sdkmeta" "github.com/charmbracelet/bubbles/help" "github.com/charmbracelet/bubbles/key" "github.com/charmbracelet/bubbles/spinner" @@ -156,7 +156,7 @@ func (m showSDKInstructionsModel) View() string { } if m.instructions == "" || m.environment == nil { - return m.spinner.View() + fmt.Sprintf(" Fetching %s SDK instructions...\n", m.displayName) + footerView(m.help.View(m.helpKeys), nil) + return m.spinner.View() + fmt.Sprintf(" Fetching %s instructions...\n", m.displayName) + footerView(m.help.View(m.helpKeys), nil) } m.help.ShowAll = true From 637a593b0420103e57ad0f45c799dc72437886cb Mon Sep 17 00:00:00 2001 From: Danny Olson Date: Tue, 13 Aug 2024 14:56:47 -0700 Subject: [PATCH 2/2] Fix formatting --- internal/quickstart/show_sdk_instructions.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/quickstart/show_sdk_instructions.go b/internal/quickstart/show_sdk_instructions.go index 9b2f230f..0db92bec 100644 --- a/internal/quickstart/show_sdk_instructions.go +++ b/internal/quickstart/show_sdk_instructions.go @@ -3,7 +3,6 @@ package quickstart import ( "fmt" - "github.com/launchdarkly/sdk-meta/api/sdkmeta" "github.com/charmbracelet/bubbles/help" "github.com/charmbracelet/bubbles/key" "github.com/charmbracelet/bubbles/spinner" @@ -11,6 +10,7 @@ import ( tea "github.com/charmbracelet/bubbletea" "github.com/charmbracelet/glamour" "github.com/charmbracelet/lipgloss" + "github.com/launchdarkly/sdk-meta/api/sdkmeta" "github.com/launchdarkly/ldcli/internal/environments" "github.com/launchdarkly/ldcli/internal/flags"