From 577b85e9edeaffa529a4b804fb4a479ae006582d Mon Sep 17 00:00:00 2001 From: "Will C." Date: Mon, 14 Apr 2025 14:25:39 -0400 Subject: [PATCH 1/2] need better error mesasge when flag key is not found in the project --- internal/dev_server/model/override.go | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/internal/dev_server/model/override.go b/internal/dev_server/model/override.go index 16eff383..5386b4d7 100644 --- a/internal/dev_server/model/override.go +++ b/internal/dev_server/model/override.go @@ -25,17 +25,12 @@ func getFlagStateForFlagAndProject(ctx context.Context, projectKey, flagKey stri return FlagState{}, err } - var flagExists bool - for flag := range project.AllFlagsState { - if flagKey == flag { - flagExists = true - break - } - } - if !flagExists { - return FlagState{}, ErrNotFound + flagState, ok := project.AllFlagsState[flagKey] + if !ok { + return FlagState{}, fmt.Errorf("%w: projectKey=%q flagKey=%q", ErrFlagNotFound, projectKey, flagKey) } - return project.AllFlagsState[flagKey], nil + + return flagState, nil } func UpsertOverride(ctx context.Context, projectKey, flagKey string, value ldvalue.Value) (Override, error) { From 36b87377688f5a8a72b180880989d833596ce2fd Mon Sep 17 00:00:00 2001 From: "Will C." Date: Mon, 14 Apr 2025 15:25:10 -0400 Subject: [PATCH 2/2] ci green --- internal/dev_server/model/override.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/dev_server/model/override.go b/internal/dev_server/model/override.go index 5386b4d7..96a23912 100644 --- a/internal/dev_server/model/override.go +++ b/internal/dev_server/model/override.go @@ -2,7 +2,7 @@ package model import ( "context" - + "fmt" "github.com/launchdarkly/go-sdk-common/v3/ldvalue" ) @@ -27,7 +27,7 @@ func getFlagStateForFlagAndProject(ctx context.Context, projectKey, flagKey stri flagState, ok := project.AllFlagsState[flagKey] if !ok { - return FlagState{}, fmt.Errorf("%w: projectKey=%q flagKey=%q", ErrFlagNotFound, projectKey, flagKey) + return FlagState{}, fmt.Errorf("%w: projectKey=%q flagKey=%q", ErrNotFound, projectKey, flagKey) } return flagState, nil