From 471324b50358028cb46db4a5b18e0a5d26a6dd16 Mon Sep 17 00:00:00 2001 From: Jacob Pierce Date: Mon, 21 Sep 2020 15:56:35 -0700 Subject: [PATCH 01/19] left & right icon buttons had unnecessary margin top margin pushed the arrows to be flush with the bottom rather than centered vertically alongside the tab buttons --- .../contentcuration/frontend/shared/views/AppBar.vue | 4 ---- 1 file changed, 4 deletions(-) diff --git a/contentcuration/contentcuration/frontend/shared/views/AppBar.vue b/contentcuration/contentcuration/frontend/shared/views/AppBar.vue index c6e20ec5a0..c59b53d838 100644 --- a/contentcuration/contentcuration/frontend/shared/views/AppBar.vue +++ b/contentcuration/contentcuration/frontend/shared/views/AppBar.vue @@ -140,10 +140,6 @@ z-index: 5; } - /deep/ .v-tabs__icon--next, - /deep/ .v-tabs__icon--prev { - margin-top: 10px; - } .kolibri-icon { border-radius: 8px; } From 8818f7edcd28b5ee43021e3be421c8c2a8c69ea3 Mon Sep 17 00:00:00 2001 From: Jacob Pierce Date: Mon, 21 Sep 2020 17:07:33 -0700 Subject: [PATCH 02/19] Use KIconButton, apply text styles and open sans This commit is too big but it is not worth breaking down into smaller commits because much of it is interconnected and I should have done so in progress --- .../channelEdit/views/files/FileUpload.vue | 2 +- .../channelList/views/Channel/ChannelItem.vue | 47 +++++++++++++------ .../channelList/views/Channel/ChannelStar.vue | 4 +- .../frontend/shared/styles/main.less | 19 +++++++- .../frontend/shared/views/IconButton.vue | 46 ++++++++---------- .../frontend/shared/views/details/Details.vue | 2 +- .../frontend/shared/views/form/Checkbox.vue | 2 +- .../frontend/shared/vuetify/theme.js | 5 +- .../contentcuration/templates/base.html | 2 + .../templates/export/channel_detail_pdf.html | 2 +- .../export/channel_detail_pdf_condensed.html | 2 +- .../templates/export/channels_pdf.html | 8 ++-- .../templates/unsupported_browser.html | 2 +- contentcuration/genstaged.py | 8 ++++ 14 files changed, 93 insertions(+), 58 deletions(-) create mode 100644 contentcuration/genstaged.py diff --git a/contentcuration/contentcuration/frontend/channelEdit/views/files/FileUpload.vue b/contentcuration/contentcuration/frontend/channelEdit/views/files/FileUpload.vue index dd4ab9b2c9..d5ef164aa9 100644 --- a/contentcuration/contentcuration/frontend/channelEdit/views/files/FileUpload.vue +++ b/contentcuration/contentcuration/frontend/channelEdit/views/files/FileUpload.vue @@ -191,7 +191,7 @@ width: 100%; } /deep/ label { - color: black; + color: var(--text); } .v-list { padding: 0; diff --git a/contentcuration/contentcuration/frontend/channelList/views/Channel/ChannelItem.vue b/contentcuration/contentcuration/frontend/channelList/views/Channel/ChannelItem.vue index 2d4ddea30f..3aae02cf3c 100644 --- a/contentcuration/contentcuration/frontend/channelList/views/Channel/ChannelItem.vue +++ b/contentcuration/contentcuration/frontend/channelList/views/Channel/ChannelItem.vue @@ -5,7 +5,7 @@ :class="{hideHighlight}" data-test="channel-card" tabindex="0" - :to="channelRoute" + @click="goToChannelRoute" :href="channelHref" > @@ -63,34 +63,40 @@ - + > + + + + +