fix(kad): compute jobs_query_capacity accurately#5148
Conversation
junekhan
changed the title
thomaseizinger
changed the title
thomaseizinger
changed the title
jobs_query_capacity accurately
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Thank you!
Can we add a test please to ensure we don't break this in the future?
@thomaseizinger Sure thing! But frankly speaking, I'm a novice in Rust, and it may take a good amount of time to finalize the test case. And, can I ask you for a favor to show me the best test case that I can refer to in this file? I feel it can somehow speed up us a little bit. Thanks! |
Unfortunately, this area of the code is also pretty foreign to me and I don't have the bandwidth to dig into it deeply. |
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Cool! Happy to merge this without a test now.
Can you bump the version of the crate and add a changelog entry? See docs for details :)
|
This pull request has merge conflicts. Could you please resolve them @junekhan? 🙏 |
…ate-jobs_query_capacity # Conflicts: # protocols/kad/CHANGELOG.md
junekhan
force-pushed
the
fix/compute-accurate-jobs_query_capacity
branch
from
321c4bc to
52d88d3
Compare
mergify
Bot
dismissed stale reviews from thomaseizinger and jxs
Approvals have been dismissed because the PR was updated after the send-it label was applied.
3 participants
Description
Fixes: #4191.
Notes & open questions