From 802c32c37469a3c62ba21b3e2ea83816576e73f7 Mon Sep 17 00:00:00 2001 From: Eli Ma Date: Sun, 28 Sep 2025 11:27:47 +0800 Subject: [PATCH 1/2] Fix tests case Signed-off-by: Eli Ma --- Cargo.toml | 3 +++ src/zstdelta/zstdelta.rs | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index c1a28b3e..ad626cce 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -43,6 +43,9 @@ zstd-sys = { version = "2.0.15+zstd.1.5.7", features = ["experimental"] } [dev-dependencies] tokio = { version = "1.45.1", features = ["full"] } tokio-util = { version = "0.7.15", features = ["io"] } +quickcheck = "1.0.3" +rand = "0.9.2" +rand_chacha = "0.9.0" [features] default = ["diff_mydrs"] diff --git a/src/zstdelta/zstdelta.rs b/src/zstdelta/zstdelta.rs index b16f1436..eafc1027 100644 --- a/src/zstdelta/zstdelta.rs +++ b/src/zstdelta/zstdelta.rs @@ -160,8 +160,8 @@ pub fn apply(base: &[u8], delta: &[u8]) -> io::Result> { mod tests { use quickcheck::quickcheck; use rand::RngCore; - use rand::SeedableRng; use rand_chacha::ChaChaRng; + use rand::SeedableRng; use super::*; @@ -184,7 +184,7 @@ mod tests { fn test_delta_efficiency() { // 1 MB incompressible random data let mut base = vec![0u8; 1000000]; - ChaChaRng::from_seed([0; 32]).fill_bytes(base.as_mut()); + ChaChaRng::from_seed([0; 32]).fill_bytes(&mut base); // Change a few bytes let mut data = base.clone(); data[0] ^= 1; From 70470dde7791af95982e8500769fccfd220e6a1a Mon Sep 17 00:00:00 2001 From: Eli Ma Date: Sun, 28 Sep 2025 11:42:28 +0800 Subject: [PATCH 2/2] Fix with Copilot suggestions Signed-off-by: Eli Ma --- src/zstdelta/zstdelta.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/zstdelta/zstdelta.rs b/src/zstdelta/zstdelta.rs index eafc1027..d88bd398 100644 --- a/src/zstdelta/zstdelta.rs +++ b/src/zstdelta/zstdelta.rs @@ -184,7 +184,8 @@ mod tests { fn test_delta_efficiency() { // 1 MB incompressible random data let mut base = vec![0u8; 1000000]; - ChaChaRng::from_seed([0; 32]).fill_bytes(&mut base); + let mut rng = ChaChaRng::from_seed([0; 32]); + rng.fill_bytes(&mut base); // Change a few bytes let mut data = base.clone(); data[0] ^= 1;