-
Notifications
You must be signed in to change notification settings - Fork 445
Open
Description
We have likely few redundant checks in send_htlc (see #1054 (comment)), cleaning them would ease the refactoring of our fee(s) accounting helpers (next_local_commit_tx_msat, get_inbound_htlcs, build_commitment, etc) as consumed by the affordance checks at HTLC sending and reception. There is at least fixing the check in update_add_htlc by using the correct anticipated value instead of value_to_self_msat (see #1054 (comment)). And likely adding test coverage, especially w.rt handling of dust/dust_limit_satoshis.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels