Cross-platform menu issues (for Runebender)

[raphlinus]

I'm doing most my Runebender development on Windows, and have come across some issues related to menus. This is a tracking issue for those.

• The Runebender source uses platform_menus::mac menus directly, without any kind of configuration check. Those use RawMods::Meta, which bind to Windows, and that doesn't work.

• The shortcuts ("Ctrl-S") are not displayed in Windows menus. I think that was intended for a while, but I didn't quite get around to implementing them. There was churn around HotKey but I think that's stabilized reasonably well now thanks to the keyboard work.

• The provided menus are missing alt-key shortcuts. These appear to work, by adding an ampersand in the localized string (&File, E&xit, etc), and are stripped out (at least on mac, haven't tested Linux yet).

The most expedient fix to the first problem is to switch from RawMods to SysMods::Cmd. That would result in reasonable behavior if menus for the wrong platform were used, if not the most platform-appropriate keybindings. A deeper change would be to expand the platform_menus::common choices, and more aggressively enforce the use of actual platform specific menus.

I have local patches with expedient fixes for most of this, and plan to PR them. I'm open to discussion about the right way to proceed, and of course if people want to take on more extensive rework.

[kud1ing]

Not sure whether it fits here, but on Mac the "Quit" entry should be last. While on Mac Rundender it is the 3rd last.

[raphlinus]

Technically, that's a Runebender issue, but it's relevant to discuss here, as the point is how we can best support a native-feeling menu structure appropriate to each platform.

ETA: actually I think that might be a deeper issue. I haven't investigated fully, but I believe the reason those are showing up on the application menu is that they are not included in the Edit menu, which I believe is where they should be. Of course, it's also the case that those two items won't work until we do IME, but that's another kettle of fish (and one for which I think we should have a tracking issue).

[kud1ing]

they are not included in the Edit menu, which I believe is where they should be.

Indeed, you're right about this.

[kud1ing]

Another thing is that it should be "runebender" instead of "Druid" obviously.

[raphlinus]

Indeed. That's because -app-name is set in resources/en-US/builtin.ftl. I'm not familiar enough with Fluent (or perhaps it's our ResourceManager) to know how easy it is to override that from the app.

[kud1ing]

Regarding the application menu on Mac: wxWidgets and Qt both appear to do the right thing for the developer.

• wxWidgets seems to identify the menu entries either by name or by ID: https://wiki.wxwidgets.org/WxMac-specific_topics#Special_Menu_Items and then moves them to the right place.

[cmyr]

Those two misplaced items are being added for us by AppKit at some point, I'll have to look into that.