Skip to content

Commit 4ce8ba1

Browse files
0.24.5
1 parent 4ac2679 commit 4ce8ba1

File tree

4 files changed

+44
-43
lines changed

4 files changed

+44
-43
lines changed

js/.changeset/issue-89-show-virtual-docker-pull-command.md

Lines changed: 0 additions & 40 deletions
This file was deleted.

js/CHANGELOG.md

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,46 @@
11
# start-command
22

3+
## 0.24.5
4+
5+
### Patch Changes
6+
7+
- 1fa812f: fix: show virtual docker pull command before Docker availability errors (issue #89)
8+
9+
When running `$ --isolated docker --image <image> -- <command>` and Docker is
10+
not installed or not running, `start-command` now shows the virtual
11+
`$ docker pull <image>` command that was being attempted before displaying the
12+
error message.
13+
14+
Before:
15+
16+
```
17+
│ isolation docker
18+
│ mode attached
19+
│ image konard/sandbox
20+
│ container docker-1773150604263-i87zla
21+
22+
Error: Docker is not installed. Install Docker from https://docs.docker.com/get-docker/
23+
```
24+
25+
After:
26+
27+
```
28+
│ isolation docker
29+
│ mode attached
30+
│ image konard/sandbox
31+
│ container docker-1773150604263-i87zla
32+
33+
$ docker pull konard/sandbox
34+
35+
36+
37+
38+
Error: Docker is not installed. Install Docker from https://docs.docker.com/get-docker/
39+
```
40+
41+
This makes it clear to users what `start-command` was attempting to do and
42+
why Docker is needed, improving the debugging experience.
43+
344
## 0.24.4
445

546
### Patch Changes

js/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "start-command",
3-
"version": "0.24.4",
3+
"version": "0.24.5",
44
"description": "Gamification of coding, execute any command with ability to auto-report issues on GitHub",
55
"main": "src/bin/cli.js",
66
"exports": {

0 commit comments

Comments
 (0)