Skip to content

fix: [DI-29314] - Wrong time range sent in metrics payload on preference reload in CloudPulse metrics #13287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
venkymano-akamai merged 8 commits into from
Jan 21, 2026
Merged

fix: [DI-29314] - Wrong time range sent in metrics payload on preference reload in CloudPulse metrics #13287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
204179f
[DI-29167] - Time range preferences bug fix
venkymano-akamai Jan 15, 2026
27fe561
Update dependencies in GlobalFilters component
venkymano-akamai Jan 16, 2026
ccfb3b0
Merge branch 'develop' into time_range_reset_issue_fix
venkymano-akamai Jan 16, 2026
97d1d43
fix: [DI-29314] - changeset and code refactoring
venkymano-akamai Jan 16, 2026
1a7e26b
Merge branch 'develop' of github.com:linode/manager into time_range_r…
venkymano-akamai Jan 17, 2026
f0bf72a
fix: [DI-29314] - code refactoring
venkymano-akamai Jan 17, 2026
9bf5177
Merge branch 'develop' into time_range_reset_issue_fix
venkymano-akamai Jan 20, 2026
8bac111
Merge branch 'develop' into time_range_reset_issue_fix
venkymano-akamai Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-13287-fixed-1768562046475.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Fixed
---

Wrong time range sent in metrics payload on preference reload in `CloudPulse metrics` ([#13287](https://github.com/linode/manager/pull/13287))
14 changes: 8 additions & 6 deletions packages/manager/src/features/CloudPulse/Dashboard/CloudPulseDashboardLanding.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,15 @@ export const CloudPulseDashboardLanding = () => {
);

const onDashboardChange = React.useCallback(
(dashboardObj: Dashboard) => {
(dashboardObj: Dashboard, skipReset: boolean = false) => {
setDashboard(dashboardObj);
setFilterData({
id: {},
label: {},
}); // clear the filter values on dashboard change
setTimeDuration(defaultTimeDuration(timezone)); // clear time duration on dashboard change
if (!skipReset) {
setFilterData({
id: {},
label: {},
}); // clear the filter values on dashboard change
setTimeDuration(defaultTimeDuration(timezone)); // clear time duration on dashboard change
}
},
[timezone]
);
Expand Down
12 changes: 9 additions & 3 deletions packages/manager/src/features/CloudPulse/Overview/GlobalFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@
filterValue: FilterValueType,
labels: string[]
): void;
handleDashboardChange(dashboard: Dashboard | undefined): void;
handleDashboardChange(
dashboard: Dashboard | undefined,
skipReset?: boolean
): void;
handleGroupByChange: (selectedValues: string[]) => void;
handleTimeDurationChange(timeDuration: DateTimeWithPreset): void;
handleToggleAppliedFilter(isVisible: boolean): void;
Expand Down Expand Up @@ -73,9 +76,12 @@
});
}
setSelectedDashboard(dashboard);
handleDashboardChange(dashboard);
handleDashboardChange(
dashboard,
preferences?.[DASHBOARD_ID] === dashboard?.id
Comment thread
venkymano-akamai marked this conversation as resolved.
);
},
[]
[preferences, handleDashboardChange]

Check warning on line 84 in packages/manager/src/features/CloudPulse/Overview/GlobalFilters.tsx

View workflow job for this annotation

GitHub Actions / ESLint Review (manager) 

[eslint] reported by reviewdog 🐶
React Hook React.useCallback has a missing dependency: 'updatePreferences'. Either include it or remove the dependency array.

Raw Output:
{"ruleId":"react-hooks/exhaustive-deps","severity":1,"message":"React Hook React.useCallback has a missing dependency: 'updatePreferences'. Either include it or remove the dependency array.","line":84,"column":5,"nodeType":"ArrayExpression","endLine":84,"endColumn":41,"suggestions":[{"desc":"Update the dependencies array to be: [handleDashboardChange, preferences, updatePreferences]","fix":{"range":[2828,2864],"text":"[handleDashboardChange, preferences, updatePreferences]"}}]}
);

const emitFilterChange = React.useCallback(
Expand Down
1 change: 1 addition & 0 deletions packages/manager/src/features/CloudPulse/shared/CloudPulseDashboardSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ export const CloudPulseDashboardSelect = React.memo(
// only call this code when the component is rendered initially
if (
(savePreferences || !!serviceType) &&
!dashboardsLoading &&
dashboardsList.length > 0 &&
selectedDashboard === undefined
) {
Expand Down