From 40ccf3c1f5c93dd18f94dad95aa48d97da504283 Mon Sep 17 00:00:00 2001 From: kagora Date: Wed, 28 Jan 2026 14:03:32 +0100 Subject: [PATCH] change: [DPS-36289] - Logs, mark Log Path field as optional --- .../.changeset/pr-13338-changed-1769606596075.md | 5 +++++ .../DestinationForm/DestinationCreate.test.tsx | 12 +++++++++--- .../DestinationForm/DestinationEdit.test.tsx | 2 +- .../DestinationAkamaiObjectStorageDetailsForm.tsx | 1 + .../StreamForm/Delivery/StreamFormDelivery.test.tsx | 4 +++- .../Streams/StreamForm/StreamCreate.test.tsx | 4 +++- .../Delivery/Streams/StreamForm/StreamEdit.test.tsx | 4 +++- 7 files changed, 25 insertions(+), 7 deletions(-) create mode 100644 packages/manager/.changeset/pr-13338-changed-1769606596075.md diff --git a/packages/manager/.changeset/pr-13338-changed-1769606596075.md b/packages/manager/.changeset/pr-13338-changed-1769606596075.md new file mode 100644 index 00000000000..f656813f29b --- /dev/null +++ b/packages/manager/.changeset/pr-13338-changed-1769606596075.md @@ -0,0 +1,5 @@ +--- +"@linode/manager": Changed +--- + +Logs - (optional) text added to Log Path Prefix field label ([#13338](https://github.com/linode/manager/pull/13338)) diff --git a/packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationCreate.test.tsx b/packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationCreate.test.tsx index d69ff14db29..2f3269e76ca 100644 --- a/packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationCreate.test.tsx +++ b/packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationCreate.test.tsx @@ -68,7 +68,9 @@ describe('DestinationCreate', () => { await userEvent.type(accessKeyIDInput, 'Test'); const secretAccessKeyInput = screen.getByLabelText('Secret Access Key'); await userEvent.type(secretAccessKeyInput, 'Test'); - const logPathPrefixInput = screen.getByLabelText('Log Path Prefix'); + const logPathPrefixInput = screen.getByLabelText( + 'Log Path Prefix (optional)' + ); await userEvent.type(logPathPrefixInput, 'Test'); expect(destinationNameInput).toHaveValue('Test'); @@ -101,7 +103,9 @@ describe('DestinationCreate', () => { expect(samplePath).toBeInTheDocument(); }); // Type the test value inside the input - const logPathPrefixInput = screen.getByLabelText('Log Path Prefix'); + const logPathPrefixInput = screen.getByLabelText( + 'Log Path Prefix (optional)' + ); await userEvent.type(logPathPrefixInput, 'test'); // sample path should be created based on *log path* value @@ -218,7 +222,9 @@ describe('DestinationCreate', () => { await userEvent.type(accessKeyIDInput, 'Test'); const secretAccessKeyInput = screen.getByLabelText('Secret Access Key'); await userEvent.type(secretAccessKeyInput, 'Test'); - const logPathPrefixInput = screen.getByLabelText('Log Path Prefix'); + const logPathPrefixInput = screen.getByLabelText( + 'Log Path Prefix (optional)' + ); await userEvent.type(logPathPrefixInput, 'Test'); }; diff --git a/packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationEdit.test.tsx b/packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationEdit.test.tsx index 4e169f7e167..ad5412fc8e9 100644 --- a/packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationEdit.test.tsx +++ b/packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationEdit.test.tsx @@ -55,7 +55,7 @@ describe('DestinationEdit', () => { assertInputHasValue('Bucket', 'destinations-bucket-name'); assertInputHasValue('Access Key ID', 'Access Id'); assertInputHasValue('Secret Access Key', ''); - assertInputHasValue('Log Path Prefix', 'file'); + assertInputHasValue('Log Path Prefix (optional)', 'file'); }); describe('given Test Connection and Edit Destination buttons', () => { diff --git a/packages/manager/src/features/Delivery/Shared/DestinationAkamaiObjectStorageDetailsForm.tsx b/packages/manager/src/features/Delivery/Shared/DestinationAkamaiObjectStorageDetailsForm.tsx index bf0b76015cb..48d0c75af65 100644 --- a/packages/manager/src/features/Delivery/Shared/DestinationAkamaiObjectStorageDetailsForm.tsx +++ b/packages/manager/src/features/Delivery/Shared/DestinationAkamaiObjectStorageDetailsForm.tsx @@ -140,6 +140,7 @@ export const DestinationAkamaiObjectStorageDetailsForm = ({ label="Log Path Prefix" onBlur={field.onBlur} onChange={(value) => field.onChange(value)} + optional placeholder="Prefix for log storage path" sx={{ maxWidth: 416 }} value={field.value} diff --git a/packages/manager/src/features/Delivery/Streams/StreamForm/Delivery/StreamFormDelivery.test.tsx b/packages/manager/src/features/Delivery/Streams/StreamForm/Delivery/StreamFormDelivery.test.tsx index 16e17569225..834e1a39f5a 100644 --- a/packages/manager/src/features/Delivery/Streams/StreamForm/Delivery/StreamFormDelivery.test.tsx +++ b/packages/manager/src/features/Delivery/Streams/StreamForm/Delivery/StreamFormDelivery.test.tsx @@ -249,7 +249,9 @@ describe('StreamFormDelivery', () => { ); // Type the test value inside the input - const logPathPrefixInput = screen.getByLabelText('Log Path Prefix'); + const logPathPrefixInput = screen.getByLabelText( + 'Log Path Prefix (optional)' + ); await userEvent.type(logPathPrefixInput, 'Test'); expect(logPathPrefixInput.getAttribute('value')).toEqual('Test'); diff --git a/packages/manager/src/features/Delivery/Streams/StreamForm/StreamCreate.test.tsx b/packages/manager/src/features/Delivery/Streams/StreamForm/StreamCreate.test.tsx index 388cbc762ea..9da162bea89 100644 --- a/packages/manager/src/features/Delivery/Streams/StreamForm/StreamCreate.test.tsx +++ b/packages/manager/src/features/Delivery/Streams/StreamForm/StreamCreate.test.tsx @@ -63,7 +63,9 @@ describe('StreamCreate', () => { await userEvent.type(accessKeyIDInput, 'Test'); const secretAccessKeyInput = screen.getByLabelText('Secret Access Key'); await userEvent.type(secretAccessKeyInput, 'Test'); - const logPathPrefixInput = screen.getByLabelText('Log Path Prefix'); + const logPathPrefixInput = screen.getByLabelText( + 'Log Path Prefix (optional)' + ); await userEvent.type(logPathPrefixInput, 'Test'); }; diff --git a/packages/manager/src/features/Delivery/Streams/StreamForm/StreamEdit.test.tsx b/packages/manager/src/features/Delivery/Streams/StreamForm/StreamEdit.test.tsx index deab21e2c4f..0cf53b24df3 100644 --- a/packages/manager/src/features/Delivery/Streams/StreamForm/StreamEdit.test.tsx +++ b/packages/manager/src/features/Delivery/Streams/StreamForm/StreamEdit.test.tsx @@ -104,7 +104,9 @@ describe('StreamEdit', () => { await userEvent.type(accessKeyIDInput, 'Test'); const secretAccessKeyInput = screen.getByLabelText('Secret Access Key'); await userEvent.type(secretAccessKeyInput, 'Test'); - const logPathPrefixInput = screen.getByLabelText('Log Path Prefix'); + const logPathPrefixInput = screen.getByLabelText( + 'Log Path Prefix (optional)' + ); await userEvent.type(logPathPrefixInput, 'Test'); };