fix:[UIE-10720] fixed lke version upgrade logic#13562
Merged
Merged
Conversation
tvijay-akamai
requested review from
abailly-akamai,
grevanak-akamai,
harsh-akamai and
tanushree-akamai
abailly-akamai
approved these changes
Apr 8, 2026
Contributor
|
Need to add changeset for this fix. |
grevanak-akamai
approved these changes
Apr 8, 2026
Closed
grevanak-akamai
pushed a commit
that referenced
this pull request
Apr 23, 2026
* fix:[UIE-10720] fixed lke version upgrade logic * fix:[UIE-10720] added changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Fixed lke version upgrade logic
Changes 🔄
Changed bare .sort() which was just JavaScript's default lexicographic comparison. The correct comparator was already existing started utilizing that compareByKuberenetesVersion
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
April End
Preview 📷
Verification steps
Go to kubernetes, on cluster list find cluster with upgrade chip and check the upgrade banner message. Should show the correct version to upgrade to
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅