Skip to content

fix: add X-Deepin-Singleton flag to desktop file (#392841) - #91

Closed
add-uos wants to merge 1 commit into
linuxdeepin:masterfrom
add-uos:task-392841-add-x-deepin-singleton-flag
Closed

fix: add X-Deepin-Singleton flag to desktop file (#392841)#91
add-uos wants to merge 1 commit into
linuxdeepin:masterfrom
add-uos:task-392841-add-x-deepin-singleton-flag

Conversation

@add-uos

@add-uos add-uos commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Add X-Deepin-Singleton=true to desktop file to mark the application as a singleton app. This allows AM to identify singleton apps and inform Treeland to skip the splash screen for these apps.

Refs: https://pms.uniontech.com/task-view-392841.html

Summary by Sourcery

Enhancements:

  • Add the X-Deepin-Singleton=true flag to the deepin-ocr desktop entry to identify it as a singleton application.

@sourcery-ai

sourcery-ai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds the X-Deepin-Singleton flag to the deepin-ocr desktop entry so the application is treated as a singleton and its splash screen can be skipped by Treeland via AM integration.

File-Level Changes

Change Details Files
Declare the OCR application as a singleton via desktop entry metadata so AM/Treeland can skip its splash screen.
  • Add X-Deepin-Singleton=true key to the desktop file entry
  • Ensure the new key is placed in the main application section alongside existing desktop metadata
deepin-ocr.desktop

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Add X-Deepin-Singleton=true to desktop file to mark the
application as a singleton app.

为单例应用的desktop文件添加X-Deepin-Singleton=true标识。

Log: 添加单例应用标识
PMS: TASK-392841
Influence: AM能识别单例应用,Treeland不再为单例应用显示快速启动画面
@add-uos
add-uos force-pushed the task-392841-add-x-deepin-singleton-flag branch from 9bff8d8 to 2613eef Compare July 17, 2026 02:43
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码通过配置桌面环境单例属性有效解决了应用重复启动的问题
逻辑正确且符合规范,无安全漏洞

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

deepin-ocr.desktop 文件中新增 X-Deepin-Singleton=true,符合 INI 格式规范,键值对书写正确
潜在问题:无
建议:无需修改

  • 2.代码质量(符合规范)✓

配置项放置在 X-Deepin-Vendor 等其他 X-Deepin 扩展属性附近,位置合理,注释清晰
潜在问题:无
建议:无需修改

  • 3.代码性能(无性能问题)✓

启用单例模式可避免用户多次点击图标时启动多个 deepin-ocr 进程,有效节省系统内存和 CPU 资源
潜在问题:无
建议:无需修改

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次修改仅为 .desktop 文件的属性配置,不涉及任何外部输入处理、文件操作或网络通信,无安全风险

  • 建议:无需修改

■ 【改进建议代码示例】

 NoDisplay=true
 X-Deepin-ManualID=deepin-ocr
 X-Deepin-Vendor=deepin
 X-Deepin-TurboType=dtkwidget
 X-Deepin-Singleton=true

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind closed this Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants