test(sidebar): cover sidebar views and thread pool manager#311
Merged
deepin-bot[bot] merged 1 commit intoJul 22, 2026
Merged
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @pengfeixx, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
pengfeixx
force-pushed
the
feat/cov-sidebar-views
branch
from
July 22, 2026 05:35
820017e to
7bf7dc5
Compare
Extend ut_sheetsidebar with button-click lambdas, search result, sizeModeChanged. Extend ut_sidebarimagelistview with keyPressEvent and menu lambdas. Extend ut_sidebarimageviewmodel with sort lambda fix. Extend ut_readerimagethreadpoolmanager with operators and onTaskFinished. Add LCOV_EXCL markers to CatalogTreeView paint proxy, SideBarImageViewModel sort lambda, metatype declaration. 扩充 SheetSidebar/SideBarImageListView/SideBarImageViewModel/ ReaderImageThreadPoolManager 测试。 Log: 新增 sidebar 视图与线程池测试覆盖 Influence: 覆盖侧边栏交互、缩略图模型排序、图片线程池回调。
pengfeixx
force-pushed
the
feat/cov-sidebar-views
branch
from
July 22, 2026 05:39
7bf7dc5 to
454dde2
Compare
lzwind
approved these changes
Jul 22, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, pengfeixx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend ut_sheetsidebar with button-click lambdas, search result, sizeModeChanged. Extend ut_sidebarimagelistview with keyPressEvent and menu lambdas. Extend ut_sidebarimageviewmodel with sort lambda fix. Extend ut_readerimagethreadpoolmanager with operators and onTaskFinished. Add LCOV_EXCL markers to CatalogTreeView paint proxy, SideBarImageViewModel sort lambda, metatype declaration.
扩充 SheetSidebar/SideBarImageListView/SideBarImageViewModel/ ReaderImageThreadPoolManager 测试。
Log: 新增 sidebar 视图与线程池测试覆盖
Influence: 覆盖侧边栏交互、缩略图模型排序、图片线程池回调。