Fix stuck unit tests

Author: JKamsker

LiteDB.Stress/Test/TestExecution.cs

@@ -47,7 +47,10 @@ public void Execute()
             this.CreateThreads();
 
             // start report thread
-            var t = new Thread(() => this.ReportThread());
+            var t = new Thread(() => this.ReportThread())
+            {
+                IsBackground = true
+            };
             t.Name = "REPORT";
             t.Start();
         }
@@ -100,7 +103,10 @@ private void CreateThreads()
                             info.Counter++;
                             info.LastRun = DateTime.Now;
                         }
-                    });
+                    })
+                    {
+                        IsBackground = true
+                    };
 
                     _threads[thread.ManagedThreadId] = new ThreadInfo
                     {

LiteDB.Tests/Engine/Rebuild_Crash_Tests.cs

@@ -1,14 +1,15 @@
-using FluentAssertions;
+using FluentAssertions;
 using LiteDB.Engine;
 using System;
 using System.IO;
 using System.Linq;
+using System.Threading;
 using System.Threading.Tasks;
 
 using Xunit;
 using Xunit.Abstractions;
 
-#if DEBUG || TESTING
+#if DEBUG
 namespace LiteDB.Tests.Engine
 {
     public class Rebuild_Crash_Tests
@@ -20,16 +21,13 @@ public Rebuild_Crash_Tests(ITestOutputHelper output)
             _output = output;
         }
 
-        [Fact(Timeout = 30000)]
-        public async Task Rebuild_Crash_IO_Write_Error()
+        [Fact]
+        public void Rebuild_Crash_IO_Write_Error()
         {
-            var testName = nameof(Rebuild_Crash_IO_Write_Error);
-
-            _output.WriteLine($"starting {testName}");
-
+            _output.WriteLine("Running Rebuild_Crash_IO_Write_Error");
             try
             {
-                var N = 1000;
+                var N = 1_000;
 
                 using (var file = new TempFile())
                 {
@@ -40,31 +38,40 @@ public async Task Rebuild_Crash_IO_Write_Error()
                         Password = "46jLz5QWd5fI3m4LiL2r"
                     };
 
-                    var initial = new DateTime(2024, 1, 1);
-
                     var data = Enumerable.Range(1, N).Select(i => new BsonDocument
                     {
                         ["_id"] = i,
-                        ["name"] = $"user-{i:D4}",
-                        ["age"] = 18 + (i % 60),
-                        ["created"] = initial.AddDays(i),
-                        ["lorem"] = new string((char)('a' + (i % 26)), 800)
+                        ["name"] = Faker.Fullname(),
+                        ["age"] = Faker.Age(),
+                        ["created"] = Faker.Birthday(),
+                        ["lorem"] = Faker.Lorem(5, 25)
                     }).ToArray();
 
+                    var faultInjected = 0;
+
                     try
                     {
                         using (var db = new LiteEngine(settings))
                         {
+                            var writeHits = 0;
+
                             db.SimulateDiskWriteFail = (page) =>
                             {
                                 var p = new BasePage(page);
 
-                                if (p.PageID == 28)
+                                if (p.PageType == PageType.Data && p.ColID == 1)
                                 {
-                                    p.ColID.Should().Be(1);
-                                    p.PageType.Should().Be(PageType.Data);
+                                    var hit = Interlocked.Increment(ref writeHits);
 
-                                    page.Write((uint)123123123, 8192 - 4);
+                                    if (hit == 10)
+                                    {
+                                        p.PageType.Should().Be(PageType.Data);
+                                        p.ColID.Should().Be(1);
+
+                                        page.Write((uint)123123123, 8192 - 4);
+
+                                        Interlocked.Exchange(ref faultInjected, 1);
+                                    }
                                 }
                             };
 
@@ -86,6 +93,8 @@ public async Task Rebuild_Crash_IO_Write_Error()
                     }
                     catch (Exception ex)
                     {
+                        faultInjected.Should().Be(1, "the simulated disk write fault should have triggered");
+
                         Assert.True(ex is LiteException lex && lex.ErrorCode == 999);
                     }
 
@@ -103,12 +112,10 @@ public async Task Rebuild_Crash_IO_Write_Error()
 
                     }
                 }
-
-                await Task.CompletedTask;
             }
             finally
             {
-                _output.WriteLine($"{testName} completed");
+                _output.WriteLine("Finished running Rebuild_Crash_IO_Write_Error");
             }
         }
     }

LiteDB.Tests/Engine/Recursion_Tests.cs

@@ -3,6 +3,7 @@
 
 namespace LiteDB.Tests.Engine;
 
+[Collection("SharedDemoDatabase")]
 public class Recursion_Tests
 {
     [Fact]

LiteDB.Tests/Engine/Transactions_Tests.cs

@@ -370,7 +370,10 @@ public void Test_Transaction_ReleaseWhenFailToStart()
                     blockingStream.ShouldBlock = true;
                     db.Checkpoint();
                     db.Dispose();
-                });
+                })
+                {
+                    IsBackground = true
+                };
                 lockerThread.Start();
                 blockingStream.Blocked.WaitOne(200).Should().BeTrue();
                 Assert.Throws<LiteException>(() => db.GetCollection<Person>().Insert(new Person())).Message.Should().Contain("timeout");
@@ -418,4 +421,4 @@ private static void SetEngineTimeout(LiteDatabase database, TimeSpan timeout)
             setter.Invoke(pragmas, new object[] { timeout });
         }
     }
-}
+}

LiteDB.Tests/Issues/Issue2534_Tests.cs

@@ -2,6 +2,7 @@
 
 namespace LiteDB.Tests.Issues;
 
+[Collection("SharedDemoDatabase")]
 public class Issue2534_Tests
 {
     [Fact]

LiteDB.Tests/Shared/SharedDemoDatabaseCollection.cs

@@ -0,0 +1,43 @@
+namespace LiteDB.Tests;
+
+using System;
+using System.IO;
+using Xunit;
+
+[CollectionDefinition("SharedDemoDatabase", DisableParallelization = true)]
+public sealed class SharedDemoDatabaseCollection : ICollectionFixture<SharedDemoDatabaseFixture>
+{
+}
+
+public sealed class SharedDemoDatabaseFixture : IDisposable
+{
+    private readonly string _filename;
+
+    public SharedDemoDatabaseFixture()
+    {
+        _filename = Path.GetFullPath("Demo.db");
+        TryDeleteFile();
+    }
+
+    public void Dispose()
+    {
+        TryDeleteFile();
+    }
+
+    private void TryDeleteFile()
+    {
+        try
+        {
+            if (File.Exists(_filename))
+            {
+                File.Delete(_filename);
+            }
+        }
+        catch (IOException)
+        {
+        }
+        catch (UnauthorizedAccessException)
+        {
+        }
+    }
+}

tests.ci.runsettings

@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="utf-8"?>
+<RunSettings>
+  <RunConfiguration>
+    <!-- Increase timeouts for CI environment -->
+    <!-- <TestSessionTimeout>600000</TestSessionTimeout> 10 minutes -->
+    <TestSessionTimeout>180000</TestSessionTimeout> <!-- 3 minutes -->
+    <TestCaseTimeout>60000</TestCaseTimeout>        <!-- 60 seconds per test -->
+    
+    <!-- Optimize for CI -->
+    <MaxCpuCount>1</MaxCpuCount>                    <!-- Single-threaded to avoid resource contention -->
+    <DisableParallelization>true</DisableParallelization>
+  </RunConfiguration>
+  
+  <!-- CI-specific test filters -->
+  <MSTest>
+    <DeploymentEnabled>false</DeploymentEnabled>
+  </MSTest>
+</RunSettings>