-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(anthropic): recreate stream on retry #5820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
he-yufeng
wants to merge
1
commit into
livekit:main
Choose a base branch
from
he-yufeng:fix/anthropic-stream-retry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+76
−28
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Instance state not reset between retries in
_run(), causing stale_ignoring_cotand_tool_call_idon retryNow that retries actually work (the core purpose of this PR),
_run()can be called multiple times by_main_task()(livekit-agents/livekit/agents/llm/llm.py:215-223). However,_run()does not reset instance state variables (_tool_call_id,_fnc_name,_fnc_raw_arguments,_ignoring_cot,_input_tokens,_output_tokens, etc.) at the start of each attempt. If a first attempt partially processes stream events before failing with a retryable error, the stale state carries into the retry.Two concrete failure modes:
_ignoring_cotstuck True: If the first attempt receives a<thinking>text delta (line 367-368) before failing,_ignoring_cotstays True on retry, silently dropping all text content until a</thinking>tag appears — which may never happen in the retry's fresh response._tool_call_idcauses bogus tool calls: If the first attempt receives acontent_block_startwith typetool_use(lines 356-359) before failing,_tool_call_idremains set on retry. When the retry's text block hitscontent_block_stop(line 385), theif self._tool_call_id is not Nonecheck is True, emitting a spurious tool call with stale name/arguments.Both of these are retryable scenarios (no
ChatChunkwas emitted, soretryablestays True). Other plugins like Mistral (livekit-plugins/livekit-plugins-mistralai/livekit/plugins/mistralai/llm.py:222-224) and OpenAI (livekit-plugins/livekit-plugins-openai/livekit/plugins/openai/responses/llm.py:402-403) reset their per-attempt state at the top of_run().Was this helpful? React with 👍 or 👎 to provide feedback.