From 393407e3edf2a1dba7ef671d87a571eb6c4d546f Mon Sep 17 00:00:00 2001 From: Paul Wells Date: Tue, 17 Mar 2026 17:24:26 -0700 Subject: [PATCH 1/2] export discard logger --- logger/logger.go | 11 ++++++++--- observability/reporter.go | 6 +----- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/logger/logger.go b/logger/logger.go index f6fcef2a7..52654c715 100644 --- a/logger/logger.go +++ b/logger/logger.go @@ -33,9 +33,10 @@ import ( ) var ( - discardLogger = logr.Discard() - defaultLogger Logger = LogRLogger(discardLogger) - pkgLogger Logger = LogRLogger(discardLogger) + discardLogger = logr.Discard() + discardLoggerIface = LogRLogger(discardLogger) + defaultLogger = Logger(discardLoggerIface) + pkgLogger = Logger(discardLoggerIface) ) // InitFromConfig initializes a Zap-based logger @@ -52,6 +53,10 @@ func GetLogger() Logger { return defaultLogger } +func GetDiscardLogger() Logger { + return discardLoggerIface +} + // SetLogger lets you use a custom logger. Pass in a logr.Logger with default depth func SetLogger(l Logger, name string) { defaultLogger = l.WithName(name) diff --git a/observability/reporter.go b/observability/reporter.go index a70b66b75..10c054745 100644 --- a/observability/reporter.go +++ b/observability/reporter.go @@ -1,8 +1,6 @@ package observability import ( - "github.com/go-logr/logr" - "github.com/livekit/protocol/logger" "github.com/livekit/protocol/observability/agentsobs" "github.com/livekit/protocol/observability/core_callobs" @@ -17,8 +15,6 @@ import ( const Project = "livekit" -var discardLogger = logger.LogRLogger(logr.Discard()) - type Reporter interface { Logger(name, projectID string) (logger.Logger, error) Room() roomobs.Reporter @@ -40,7 +36,7 @@ func NewReporter() Reporter { type reporter struct{} func (reporter) Logger(name, projectID string) (logger.Logger, error) { - return discardLogger, nil + return logger.GetDiscardLogger(), nil } func (reporter) Room() roomobs.Reporter { From 856ce5be7c2ff51e201c7f87aa422cb88c7ca396 Mon Sep 17 00:00:00 2001 From: Paul Wells Date: Tue, 17 Mar 2026 17:25:35 -0700 Subject: [PATCH 2/2] Create shiny-coins-relate.md --- .changeset/shiny-coins-relate.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/shiny-coins-relate.md diff --git a/.changeset/shiny-coins-relate.md b/.changeset/shiny-coins-relate.md new file mode 100644 index 000000000..8ada704c8 --- /dev/null +++ b/.changeset/shiny-coins-relate.md @@ -0,0 +1,5 @@ +--- +"@livekit/protocol": patch +--- + +export discard logger