[mlir][sparse] Add checking parent op of SortOp

sott0n · ftynse · commit 9a29d8753884 · 2023-02-27T16:37:02.000+01:00
Fix crash with segmentation fault caused by setting a parent operator that is not func::FuncOp with sparse_tensor SortOp. fixes #59988 Reviewed By: aartbik, wrengr Differential Revision: https://reviews.llvm.org/D143874
diff --git a/mlir/lib/Dialect/SparseTensor/Transforms/SparseBufferRewriting.cpp b/mlir/lib/Dialect/SparseTensor/Transforms/SparseBufferRewriting.cpp
@@ -1160,6 +1160,9 @@ LogicalResult matchAndRewriteSortOp(OpTy op, ValueRange xys, uint64_t nx,
   }
 
   auto insertPoint = op->template getParentOfType<func::FuncOp>();
+  if (!insertPoint)
+    return failure();
+
   SmallString<32> funcName;
   FuncGeneratorType funcGenerator;
   uint32_t nTrailingP = 0;

Original file line number	Diff line number	Diff line change
`@@ -1160,6 +1160,9 @@ LogicalResult matchAndRewriteSortOp(OpTy op, ValueRange xys, uint64_t nx,`
`1160`	`1160`	`}`
`1161`	`1161`
`1162`	`1162`	`auto insertPoint = op->template getParentOfType<func::FuncOp>();`
	`1163`	`+ if (!insertPoint)`
	`1164`	`+ return failure();`
	`1165`	`+`
`1163`	`1166`	`SmallString<32> funcName;`
`1164`	`1167`	`FuncGeneratorType funcGenerator;`
`1165`	`1168`	`uint32_t nTrailingP = 0;`