From dfe43e0dbcb57bf7fe8927cb74767a232354c172 Mon Sep 17 00:00:00 2001 From: Raymond Feng Date: Thu, 6 Feb 2020 08:26:58 -0800 Subject: [PATCH] chore(extension-logging): fix typos and clean up descriptions --- .../{accpetance => acceptance}/fluent.acceptance.ts | 9 ++++++--- extensions/logging/README.md | 2 +- extensions/logging/package.json | 3 ++- .../logging.component.acceptance.ts | 0 .../logging.interceptor.acceptance.ts | 0 .../{accpetance => acceptance}/winston.acceptance.ts | 0 6 files changed, 9 insertions(+), 5 deletions(-) rename acceptance/extension-logging-fluentd/src/__tests__/{accpetance => acceptance}/fluent.acceptance.ts (93%) rename extensions/logging/src/__tests__/{accpetance => acceptance}/logging.component.acceptance.ts (100%) rename extensions/logging/src/__tests__/{accpetance => acceptance}/logging.interceptor.acceptance.ts (100%) rename extensions/logging/src/__tests__/{accpetance => acceptance}/winston.acceptance.ts (100%) diff --git a/acceptance/extension-logging-fluentd/src/__tests__/accpetance/fluent.acceptance.ts b/acceptance/extension-logging-fluentd/src/__tests__/acceptance/fluent.acceptance.ts similarity index 93% rename from acceptance/extension-logging-fluentd/src/__tests__/accpetance/fluent.acceptance.ts rename to acceptance/extension-logging-fluentd/src/__tests__/acceptance/fluent.acceptance.ts index 15e22ae97cb7..3136009def38 100644 --- a/acceptance/extension-logging-fluentd/src/__tests__/accpetance/fluent.acceptance.ts +++ b/acceptance/extension-logging-fluentd/src/__tests__/acceptance/fluent.acceptance.ts @@ -11,9 +11,12 @@ import {readLog} from '../fixtures/fluentd.docker'; const sleep = promisify(setTimeout); -describe('LoggingComponent', () => { +describe('LoggingComponent', function() { let app: Application; + // eslint-disable-next-line no-invalid-this + this.timeout(10000); + beforeEach(givenAppWithCustomConfig); /* eslint-disable no-invalid-this */ @@ -21,7 +24,7 @@ describe('LoggingComponent', () => { if (process.env.FLUENTD_SERVICE_PORT_TCP == null) return this.skip(); const sender = await app.get(LoggingBindings.FLUENT_SENDER); sender.emit({greeting: 'Hello, LoopBack!'}); - await sleep(100); + await sleep(500); await expectLogsToMatch(/LoopBack\s+\{"greeting"\:"Hello, LoopBack!"\}/); }); @@ -29,7 +32,7 @@ describe('LoggingComponent', () => { if (process.env.FLUENTD_SERVICE_PORT_TCP == null) return this.skip(); const logger = await app.get(LoggingBindings.WINSTON_LOGGER); logger.log('info', 'Hello, LoopBack!'); - await sleep(100); + await sleep(500); await expectLogsToMatch( /LoopBack\s+\{"level"\:"info","message":"Hello, LoopBack!"\}/, ); diff --git a/extensions/logging/README.md b/extensions/logging/README.md index 9ac391d34949..8f8dc5a71fe9 100644 --- a/extensions/logging/README.md +++ b/extensions/logging/README.md @@ -4,7 +4,7 @@ This module contains a component provides logging facilities based on [Winston](https://github.com/winstonjs/winston) and [Fluentd](https://github.com/fluent/fluent-logger-node). -## Stability: :warning:Experimental:warning: +## Stability: ⚠️Experimental⚠️ > Experimental packages provide early access to advanced or experimental > functionality to get community feedback. Such modules are published to npm diff --git a/extensions/logging/package.json b/extensions/logging/package.json index 4dd2368b6fde..a260110434f9 100644 --- a/extensions/logging/package.json +++ b/extensions/logging/package.json @@ -1,7 +1,7 @@ { "name": "@loopback/extension-logging", "version": "0.0.1", - "description": "LoopBack Logging for Fluentd", + "description": "LoopBack Logging for Winston and Fluentd", "engines": { "node": ">=8.9" }, @@ -36,6 +36,7 @@ "LoopBack", "Cloud Native", "Fluentd", + "Winston", "Logging" ], "files": [ diff --git a/extensions/logging/src/__tests__/accpetance/logging.component.acceptance.ts b/extensions/logging/src/__tests__/acceptance/logging.component.acceptance.ts similarity index 100% rename from extensions/logging/src/__tests__/accpetance/logging.component.acceptance.ts rename to extensions/logging/src/__tests__/acceptance/logging.component.acceptance.ts diff --git a/extensions/logging/src/__tests__/accpetance/logging.interceptor.acceptance.ts b/extensions/logging/src/__tests__/acceptance/logging.interceptor.acceptance.ts similarity index 100% rename from extensions/logging/src/__tests__/accpetance/logging.interceptor.acceptance.ts rename to extensions/logging/src/__tests__/acceptance/logging.interceptor.acceptance.ts diff --git a/extensions/logging/src/__tests__/accpetance/winston.acceptance.ts b/extensions/logging/src/__tests__/acceptance/winston.acceptance.ts similarity index 100% rename from extensions/logging/src/__tests__/accpetance/winston.acceptance.ts rename to extensions/logging/src/__tests__/acceptance/winston.acceptance.ts