Skip to content

Commit 701cce3

Browse files
committed
[#3] Integrate Danger for PR review
1 parent c449383 commit 701cce3

File tree

8 files changed

+177
-1
lines changed

8 files changed

+177
-1
lines changed

.github/workflows/review_pull_request.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,3 +45,14 @@ jobs:
4545

4646
- name: Run unit tests with Kover
4747
run: ./gradlew koverMergedXmlReport
48+
49+
- name: Set up Ruby
50+
uses: ruby/setup-ruby@v1
51+
with:
52+
ruby-version: '2.7'
53+
bundler-cache: true
54+
55+
- name: Run Danger
56+
env:
57+
DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
58+
run: bundle exec danger

Dangerfile

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
# Make it more obvious that a PR is a work in progress and shouldn't be merged yet
2+
warn("PR is classed as Work in Progress") if github.pr_title.include? "WIP"
3+
4+
# Warn when there is a big PR
5+
warn("Big PR") if git.lines_of_code > 500
6+
7+
# Warn to encourage a PR description
8+
warn("Please provide a summary in the PR description to make it easier to review") if github.pr_body.length == 0
9+
10+
# Warn to encourage that labels should have been used on the PR
11+
warn("Please add labels to this PR") if github.pr_labels.empty?
12+
13+
# Check commits lint and warn on all checks (instead of failing)
14+
commit_lint.check warn: :all, disable: [:subject_length]
15+
16+
# Detekt output check
17+
detekt_dir = "build/reports/detekt/detekt.xml"
18+
Dir[detekt_dir].each do |file_name|
19+
kotlin_detekt.skip_gradle_task = true
20+
kotlin_detekt.report_file = file_name
21+
kotlin_detekt.detekt(inline_mode: true)
22+
end
23+
24+
# Android Lint output check
25+
lint_dir = "**/build/reports/lint-results-stagingDebug.xml"
26+
Dir[lint_dir].each do |file_name|
27+
android_lint.skip_gradle_task = true
28+
android_lint.report_file = file_name
29+
android_lint.lint(inline_mode: true)
30+
end
31+
32+
# Show Danger test coverage report from Kover
33+
kover_dir = "build/reports/kover/merged/xml/report.xml"
34+
Dir[kover_dir].each do |file_name|
35+
# Report coverage of modified files, warn if total project coverage is under 80%
36+
# or if any modified file's coverage is under 95%
37+
module_name = file_name.split('/', 2)[0]
38+
shroud.reportKover module_name, file_name, 80, 95, false
39+
end

Gemfile

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# frozen_string_literal: true
2+
3+
source "https://rubygems.org"
4+
5+
git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
6+
7+
# Android
8+
gem 'danger'
9+
gem 'danger-android_lint'
10+
gem 'danger-commit_lint'
11+
gem 'danger-kotlin_detekt'
12+
gem 'danger-shroud'

Gemfile.lock

Lines changed: 114 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,114 @@
1+
GEM
2+
remote: https://rubygems.org/
3+
specs:
4+
addressable (2.8.1)
5+
public_suffix (>= 2.0.2, < 6.0)
6+
ansi (1.5.0)
7+
ast (2.4.2)
8+
claide (1.1.0)
9+
claide-plugins (0.9.2)
10+
cork
11+
nap
12+
open4 (~> 1.3)
13+
colored2 (3.1.2)
14+
cork (0.3.0)
15+
colored2 (~> 3.1)
16+
danger (9.1.0)
17+
claide (~> 1.0)
18+
claide-plugins (>= 0.9.2)
19+
colored2 (~> 3.1)
20+
cork (~> 0.1)
21+
faraday (>= 0.9.0, < 2.0)
22+
faraday-http-cache (~> 2.0)
23+
git (~> 1.7)
24+
kramdown (~> 2.3)
25+
kramdown-parser-gfm (~> 1.0)
26+
no_proxy_fix
27+
octokit (~> 5.0)
28+
terminal-table (>= 1, < 4)
29+
danger-android_lint (0.0.11)
30+
danger-plugin-api (~> 1.0)
31+
oga
32+
danger-commit_lint (0.0.7)
33+
danger-plugin-api (~> 1.0)
34+
danger-kotlin_detekt (0.0.3)
35+
danger-plugin-api (~> 1.0)
36+
danger-plugin-api (1.0.0)
37+
danger (> 2.0)
38+
danger-shroud (0.0.5)
39+
danger-plugin-api (~> 1.0)
40+
nokogiri
41+
faraday (1.10.2)
42+
faraday-em_http (~> 1.0)
43+
faraday-em_synchrony (~> 1.0)
44+
faraday-excon (~> 1.1)
45+
faraday-httpclient (~> 1.0)
46+
faraday-multipart (~> 1.0)
47+
faraday-net_http (~> 1.0)
48+
faraday-net_http_persistent (~> 1.0)
49+
faraday-patron (~> 1.0)
50+
faraday-rack (~> 1.0)
51+
faraday-retry (~> 1.0)
52+
ruby2_keywords (>= 0.0.4)
53+
faraday-em_http (1.0.0)
54+
faraday-em_synchrony (1.0.0)
55+
faraday-excon (1.1.0)
56+
faraday-http-cache (2.4.1)
57+
faraday (>= 0.8)
58+
faraday-httpclient (1.0.1)
59+
faraday-multipart (1.0.4)
60+
multipart-post (~> 2)
61+
faraday-net_http (1.0.1)
62+
faraday-net_http_persistent (1.2.0)
63+
faraday-patron (1.0.0)
64+
faraday-rack (1.0.0)
65+
faraday-retry (1.0.3)
66+
git (1.12.0)
67+
addressable (~> 2.8)
68+
rchardet (~> 1.8)
69+
kramdown (2.4.0)
70+
rexml
71+
kramdown-parser-gfm (1.1.0)
72+
kramdown (~> 2.0)
73+
multipart-post (2.2.3)
74+
nap (1.1.0)
75+
no_proxy_fix (0.1.2)
76+
nokogiri (1.13.9-x86_64-darwin)
77+
racc (~> 1.4)
78+
nokogiri (1.13.9-x86_64-linux)
79+
racc (~> 1.4)
80+
octokit (5.6.1)
81+
faraday (>= 1, < 3)
82+
sawyer (~> 0.9)
83+
oga (3.4)
84+
ast
85+
ruby-ll (~> 2.1)
86+
open4 (1.3.4)
87+
public_suffix (5.0.0)
88+
racc (1.6.0)
89+
rchardet (1.8.0)
90+
rexml (3.2.5)
91+
ruby-ll (2.1.2)
92+
ansi
93+
ast
94+
ruby2_keywords (0.0.5)
95+
sawyer (0.9.2)
96+
addressable (>= 2.3.5)
97+
faraday (>= 0.17.3, < 3)
98+
terminal-table (3.0.2)
99+
unicode-display_width (>= 1.1.1, < 3)
100+
unicode-display_width (2.3.0)
101+
102+
PLATFORMS
103+
x86_64-darwin-21
104+
x86_64-linux
105+
106+
DEPENDENCIES
107+
danger
108+
danger-android_lint
109+
danger-commit_lint
110+
danger-kotlin_detekt
111+
danger-shroud
112+
113+
BUNDLED WITH
114+
2.3.25

android/src/test/java/vn/luongvo/kmm/survey/android/SampleUnitTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package vn.luongvo.kmm.survey.android
33
import org.junit.Assert.assertTrue
44
import org.junit.Test
55

6-
class AndroidTest {
6+
class SampleUnitTest {
77

88
@Test
99
fun testExample() {

shared/src/androidTest/kotlin/vn/luongvo/kmm/survey/androidTest.kt renamed to shared/src/androidTest/kotlin/vn/luongvo/kmm/survey/AndroidTest.kt

File renamed without changes.

shared/src/commonTest/kotlin/vn/luongvo/kmm/survey/commonTest.kt renamed to shared/src/commonTest/kotlin/vn/luongvo/kmm/survey/CommonTest.kt

File renamed without changes.

shared/src/iosTest/kotlin/vn/luongvo/kmm/survey/iosTest.kt renamed to shared/src/iosTest/kotlin/vn/luongvo/kmm/survey/IosTest.kt

File renamed without changes.

0 commit comments

Comments
 (0)