Add trillion unit, fix negatives, show decimals#5
Merged
Conversation
Bump version to 1.2.0 and introduce several formatting fixes and features: add support for the T (trillion) suffix in number/number_with (including rounding-promotion from B → T), make bytes_decimal/bytes_binary always show a decimal when the value is scaled to a sub-unit (KB and above) while keeping raw bytes without decimals, and handle negative seconds correctly in duration and duration_precise by formatting the absolute value and prepending a leading "-". Defensive guards were added to pow10_acc and pow_int_acc to return 1 for non‑positive exponents to prevent infinite recursion when decimals <= 0. Tests and humanize.toml were updated to reflect the new behavior and edge cases (negative durations, trillion numbers, and safe handling of non‑positive decimals).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump version to 1.2.0 and introduce several formatting fixes and features: add support for the T (trillion) suffix in number/number_with (including rounding-promotion from B → T), make bytes_decimal/bytes_binary always show a decimal when the value is scaled to a sub-unit (KB and above) while keeping raw bytes without decimals, and handle negative seconds correctly in duration and duration_precise by formatting the absolute value and prepending a leading "-". Defensive guards were added to pow10_acc and pow_int_acc to return 1 for non‑positive exponents to prevent infinite recursion when decimals <= 0. Tests and humanize.toml were updated to reflect the new behavior and edge cases (negative durations, trillion numbers, and safe handling of non‑positive decimals).