Skip to content

fix: use formula-name for release asset lookup#33

Merged
luxass merged 1 commit into
mainfrom
fix/homebrew-tarball-name
May 21, 2026
Merged

fix: use formula-name for release asset lookup#33
luxass merged 1 commit into
mainfrom
fix/homebrew-tarball-name

Conversation

@luxass

@luxass luxass commented May 21, 2026

Copy link
Copy Markdown
Owner

The compute checksums step hardcoded the asset prefix to 'actioneer', causing SHA updates to fail for other formulas like artifacthub-mcp. This change uses the formula-name input to dynamically match downloaded release assets.

Summary by CodeRabbit

  • Chores
    • Updated release build configuration to use dynamic naming for release assets based on configurable parameters instead of hardcoded values.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@luxass has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 58 minutes and 6 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c0304580-e133-46ec-ba16-bc6661613797

📥 Commits

Reviewing files that changed from the base of the PR and between b5bb948 and d8524d9.

📒 Files selected for processing (1)
  • .github/workflows/reusable-homebrew-tap.yaml

Walkthrough

The Homebrew tap workflow's checksum computation step now derives release asset filenames from the reusable workflow input formula-name instead of using a hardcoded actioneer- prefix, enabling correct SHA256 checksum output for differently-named formulas.

Changes

Homebrew release workflow

Layer / File(s) Summary
Parameterized checksum computation
.github/workflows/reusable-homebrew-tap.yaml
The compute checksums step adds FORMULA_NAME environment variable from inputs.formula-name and updates the tarball filename pattern to ${FORMULA_NAME}-${version}-${target}.tar.gz so SHA256 outputs match the actual release asset names.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • luxass/shared-workflows#28: Both PRs modify .github/workflows/reusable-homebrew-tap.yaml in the release-asset flow—one adds a checkout step before downloading, and the other changes how the downloaded asset filenames (via formula-name) are used for checksum computation—so the changes are tied to the same release-asset handling.

Poem

🐰 A formula name, no longer bound,
To actioneer's hardcoded ground—
Now parameterized and free to roam,
Each checksum finds its rightful home! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: use formula-name for release asset lookup' accurately describes the main change: updating the workflow to use the formula-name input instead of a hardcoded prefix for asset lookup.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/homebrew-tarball-name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@luxass luxass force-pushed the fix/homebrew-tarball-name branch from b5bb948 to d8524d9 Compare May 21, 2026 03:47
@luxass luxass merged commit bdbe8f5 into main May 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant