MacOS: Only activate after the application has finished launching

This fixes the main menu not responding until you refocus, at least from what I can tell - though we might have to do something similar to linebender/druid#994 to fix it fully?

Author: madsmtm

CHANGELOG.md

@@ -1,5 +1,7 @@
 # Unreleased
 
+- On macOS, wait with activating the application until the application has initialized.
+- On macOS, fix creating new windows when the application has a main menu.
 - On Windows, fix fractional deltas for mouse wheel device events.
 - On macOS, fix segmentation fault after dropping the main window.
 - On Android, `InputEvent::KeyEvent` is partially implemented providing the key scancode.

src/platform_impl/macos/app_state.rs

@@ -13,10 +13,11 @@ use std::{
 };
 
 use cocoa::{
-    appkit::{NSApp, NSWindow},
+    appkit::{NSApp, NSApplication, NSWindow},
     base::{id, nil},
     foundation::{NSAutoreleasePool, NSSize},
 };
+use objc::runtime::YES;
 
 use crate::{
     dpi::LogicalSize,
@@ -272,6 +273,11 @@ impl AppState {
     }
 
     pub fn launched() {
+        unsafe {
+            let ns_app = NSApp();
+            // TODO: Consider allowing the user to specify they don't want their application activated
+            ns_app.activateIgnoringOtherApps_(YES);
+        };
         HANDLER.set_ready();
         HANDLER.waker().start();
         HANDLER.set_in_callback(true);

src/platform_impl/macos/window.rs

@@ -360,7 +360,7 @@ impl UnownedWindow {
 
         let pool = unsafe { NSAutoreleasePool::new(nil) };
 
-        let ns_app = create_app(pl_attribs.activation_policy).ok_or_else(|| {
+        create_app(pl_attribs.activation_policy).ok_or_else(|| {
             unsafe { pool.drain() };
             os_error!(OsError::CreationError("Couldn't create `NSApplication`"))
         })?;
@@ -386,7 +386,6 @@ impl UnownedWindow {
                 ns_window.setBackgroundColor_(NSColor::clearColor(nil));
             }
 
-            ns_app.activateIgnoringOtherApps_(YES);
             win_attribs.min_inner_size.map(|dim| {
                 let logical_dim = dim.to_logical(scale_factor);
                 set_min_inner_size(*ns_window, logical_dim)