Updates to Route Manager RFC#1
Conversation
|
|
||
| interface RouteManager { | ||
| getRouteWrapper(bucket: RouteStateBucket): ComponentLike; | ||
| getRouteWrapper(bucket: RouteStateBucket): ComponentLike<Component: ComponentLike; controller: Controller; model: unknown; routeInfo: InternalRouteInfo<Route>>; |
There was a problem hiding this comment.
so this still doesn't quite look like what I expected 🤔 I expected to see the component (and maybe a reference to it being the same component returned from getInvokable... maybe we could do that with a generic or something?), I expect to see a context (not a modle), and I expected to see a route bucket passed in too.
This is clearly closer to the classicRoute manager, and we can for sure include a non-generic example to illustrate if you think that's useful, but I think we should keep this as the interface that we expect every route manager to implement
There was a problem hiding this comment.
I based these on what arguments are always curried onto the component. It's down to the wrapper component to use them or not.
wrapperArgs['Component']
wrapperArgs['routeInfo']
wrapperArgs['controller']
wrapperArgs['model']Let's talk it through in office hours.
There were a bunch of formatting differences when I saved.
Easier to see changes here