Skip to content

Updates to Route Manager RFC#1

Merged
evoactivity merged 6 commits into
nickschot/route-manager-apifrom
liampotter/route-manager-api
May 11, 2026
Merged

Updates to Route Manager RFC#1
evoactivity merged 6 commits into
nickschot/route-manager-apifrom
liampotter/route-manager-api

Conversation

@evoactivity
Copy link
Copy Markdown

@evoactivity evoactivity commented May 11, 2026

There were a bunch of formatting differences when I saved.

Easier to see changes here

Copy link
Copy Markdown
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few comments

Comment thread text/1169-route-manager-api.md Outdated
Comment thread text/1169-route-manager-api.md Outdated
Comment thread text/1169-route-manager-api.md Outdated
Comment thread text/1169-route-manager-api.md Outdated
Comment thread text/1169-route-manager-api.md Outdated

interface RouteManager {
getRouteWrapper(bucket: RouteStateBucket): ComponentLike;
getRouteWrapper(bucket: RouteStateBucket): ComponentLike<Component: ComponentLike; controller: Controller; model: unknown; routeInfo: InternalRouteInfo<Route>>;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this still doesn't quite look like what I expected 🤔 I expected to see the component (and maybe a reference to it being the same component returned from getInvokable... maybe we could do that with a generic or something?), I expect to see a context (not a modle), and I expected to see a route bucket passed in too.

This is clearly closer to the classicRoute manager, and we can for sure include a non-generic example to illustrate if you think that's useful, but I think we should keep this as the interface that we expect every route manager to implement

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I based these on what arguments are always curried onto the component. It's down to the wrapper component to use them or not.

wrapperArgs['Component']
wrapperArgs['routeInfo']
wrapperArgs['controller']
wrapperArgs['model']

Let's talk it through in office hours.

@evoactivity evoactivity merged commit 2c3fe11 into nickschot/route-manager-api May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants