Skip to content

Commit ae0d90a

Browse files
committed
Since we de-highlight guider.highlight, we should be highlighting it instead of guider.attachTo.
While it is common to set highlight to the same ID as attachTo, I often attach to one thing but highlight another--like the attachTo's container. Also, must the guider have an attachTo for a highlight to be valid? If not, the test of attachTo is also unnecessary. It's no harm right now, so I left it in.
1 parent 774fad6 commit ae0d90a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

guiders.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ var guiders = (function($) {
596596
guiders._showOverlay(myGuider);
597597
// if guider is attached to an element, make sure it's visible
598598
if (myGuider.highlight && myGuider.attachTo) {
599-
guiders._highlightElement(myGuider.attachTo);
599+
guiders._highlightElement(myGuider.highlight);
600600
}
601601
}
602602

0 commit comments

Comments
 (0)