Performance regression between iOS 0.5.2 and 0.5.3

[tomtaylor]

I've noticed a performance regression between iOS 0.5.2 and 0.5.3. I have a UI element which acts as a scrubber along a polyline (video here). I use a custom animation, driven by a CADisplayLink, to set the zoom and centre coordinate of the map every frame using a 3D spring behaviour.

In 0.5.2, the labels don't redraw until the animation stops, and during the animation the movement is smooth.

In 0.5.3, if the animation changes the zoom to the extent that the labels are due for refresh, it becomes jerky. If you pause the movement long enough for the labels to redraw, it becomes smooth again.

Let me know if you need any more information.

[friedbunny]

This sounds like it would be related to @brunoabinader's label work in #1548.

/cc @incanus

[brunoabinader]

This sounds like it would be related to @brunoabinader's label work in #1548.

We have a fix for that in #1928 (commit 5e2f3b1), which landed on version 0.5.4. @tomtaylor, is it possible to test it against version 0.5.4 instead of 0.5.3? Also, I'd love to reproduce the custom animation if you have it handy.

[tomtaylor]

Thanks - I'm away from my machine at the moment, but I'm pretty confident I tested against 0.5.4 with the same results. I'll get you the animation code when I get back.

On 1 Aug 2015, at 09:03, Bruno de Oliveira Abinader notifications@github.com wrote:

This sounds like it would be related to @brunoabinader's label work in #1548.

We have a fix for that in #1928, which landed on version 0.5.4. @tomtaylor, is it possible to test it against version 0.5.4 instead of 0.5.3? Also, I'd love to reproduce the custom animation if you have it handy.

—
Reply to this email directly or view it on GitHub.

[tomtaylor]

OK, here's the animation driver code: https://gist.github.com/tomtaylor/91d29f47f281b9d96fcd

And I can confirm the same behaviour on 0.5.4. Let me know if I can give you any more info.

[brunoabinader]

@tomtaylor I just merged #1979 into master; could you please check?

[tomtaylor]

@brunoabinader happy to, do you think you could make me a new podspec file, pointing to a precompiled .zip version?

[tomtaylor]

@brunoabinader I just managed to try this out on 2.1.0-pre.1, and I don't think it's quite fixed yet. I recorded a video through Quicktime from my 5s, which shows what I'm experiencing. For context, I'm touching on the scrubber at the bottom to zoom in at that point on the route, driven by the animation code I shared previously. Let me know if I can give you any more information.

https://s3-eu-west-1.amazonaws.com/files.tomtaylor.co.uk/data/mapbox-lag.mov

(On the flip side, it seems to perform even better when all the labels have rendered!)

[tomtaylor]

@brunoabinader @incanus should I open a new issue for this?