You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Per #8431 (comment), MGLStyle needs a light property that lets the developer set style-wide parameters like lighting color and intensity. We’ll need an MGLLight class to hold these individual properties. Hopefully we can make MGLLight consistent with SceneKit’s SCNLight and the style specification simultaneously.
One complication is that mbgl::Map::setLight() takes a std::unique_ptr instead of an mbgl::style::Light object by value (which is how mbgl::CameraOptions and mbgl::AnimationOptions work). Developers will expect MGLLight to be a value class along the lines of MGLMapCamera.
Per #8431 (comment), MGLStyle needs a
lightproperty that lets the developer set style-wide parameters like lighting color and intensity. We’ll need an MGLLight class to hold these individual properties. Hopefully we can make MGLLight consistent with SceneKit’s SCNLight and the style specification simultaneously.One complication is that
mbgl::Map::setLight()takes astd::unique_ptrinstead of anmbgl::style::Lightobject by value (which is howmbgl::CameraOptionsandmbgl::AnimationOptionswork). Developers will expect MGLLight to be a value class along the lines of MGLMapCamera./cc @fabian-guerra @lbud @jfirebaugh