Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Add light property to MGLStyle #8840

@1ec5

Description

@1ec5

Per #8431 (comment), MGLStyle needs a light property that lets the developer set style-wide parameters like lighting color and intensity. We’ll need an MGLLight class to hold these individual properties. Hopefully we can make MGLLight consistent with SceneKit’s SCNLight and the style specification simultaneously.

One complication is that mbgl::Map::setLight() takes a std::unique_ptr instead of an mbgl::style::Light object by value (which is how mbgl::CameraOptions and mbgl::AnimationOptions work). Developers will expect MGLLight to be a value class along the lines of MGLMapCamera.

/cc @fabian-guerra @lbud @jfirebaugh

Metadata

Metadata

Assignees

Labels

GL JS parityFor feature parity with Mapbox GL JSbeta blockerBlocks the next beta releaseiOSMapbox Maps SDK for iOSmacOSMapbox Maps SDK for macOSruntime styling

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions