This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[android] Hook camera events into compass#10019
Merged
Merged
Conversation
tobrun
approved these changes
Sep 19, 2017
Member
tobrun
left a comment
tobrun
left a comment
There was a problem hiding this comment.
looking good, though would love to know the intensive of moving click handling to MapView. It was placed in CompassView to encapsulate that behavior.
Contributor
Author
Wasn't 👉 https://github.com/mapbox/mapbox-gl-native/pull/10019/files#diff-134d85017f67b51137a7371964f3aa52L65 referring to that? Probably I misunderstood. I'll revert those changes. |
Member
|
I'm 👍 on the change, was just wondering. Re. that todo, was more about replacing Mapbox with transform but this also works 😉 |
20 tasks
20 tasks
20 tasks
This was referenced Nov 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompassViewCompassViewOnClickListenerintoMapView👀 @tobrun