This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Add interpolator examples#10067
Merged
Merged
Conversation
tobrun
force-pushed
the
tvn-interpolator-example
branch
from
8674ffb to
521070b
Compare
Guardiola31337
suggested changes
Sep 29, 2017
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
These examples are awesome 👏
Minor details.
| } | ||
| findViewById(R.id.fab).setVisibility(View.GONE); | ||
|
|
||
| // reset camera to init position |
Contributor
There was a problem hiding this comment.
What about extracting this block of code into a private method and give it a name based on the comment? This way onOptionsItemSelected will be easier to read and understand and comment will become superfluous so it won't be necessary.
| .build() | ||
| )); | ||
|
|
||
| // play animation |
| } | ||
|
|
||
| private Animator createExamepleInterpolator(int menuItemId) { | ||
| switch (menuItemId) { |
Contributor
There was a problem hiding this comment.
What about removing the switch using a map/dictionary? AnimatorSets could be created beforehand and inserted into a map using the different menu ids as values.
tobrun
force-pushed
the
tvn-interpolator-example
branch
from
521070b to
50d781a
Compare
Contributor
|
@tobrun I found a crash when testing these examples when clicking the different options back and forth logcatSymbolicated Android crashMoto X (2nd gen) Android 5.0 |
| } | ||
|
|
||
| private Animator createExamepleInterpolator(int menuItemId) { | ||
| switch (menuItemId) { |
Contributor
There was a problem hiding this comment.
I was thinking something like this
diff --git a/platform/android/MapboxGLAndroidSDKTestApp/src/main/java/com/mapbox/mapboxsdk/testapp/activity/camera/CameraAnimatorActivity.java b/platform/android/MapboxGLAndroidSDKTestApp/src/main/java/com/mapbox/mapboxsdk/testapp/activity/camera/CameraAnimatorActivity.java
index 134086145..c6e3c7a05 100644
--- a/platform/android/MapboxGLAndroidSDKTestApp/src/main/java/com/mapbox/mapboxsdk/testapp/activity/camera/CameraAnimatorActivity.java
+++ b/platform/android/MapboxGLAndroidSDKTestApp/src/main/java/com/mapbox/mapboxsdk/testapp/activity/camera/CameraAnimatorActivity.java
@@ -25,6 +25,9 @@ import com.mapbox.mapboxsdk.maps.MapboxMap;
import com.mapbox.mapboxsdk.maps.OnMapReadyCallback;
import com.mapbox.mapboxsdk.testapp.R;
+import java.util.HashMap;
+import java.util.Map;
+
/**
* Test activity showcasing using Android SDK animators to animate camera position changes.
*/
@@ -206,27 +209,50 @@ public class CameraAnimatorActivity extends AppCompatActivity implements OnMapRe
}
}
- private Animator createExamepleInterpolator(int menuItemId) {
- switch (menuItemId) {
- case R.id.menu_action_accelerate_decelerate_interpolator:
- AnimatorSet animatorSet = new AnimatorSet();
- animatorSet.playTogether(
- createLatLngAnimator(START_LAT_LNG, new LatLng(37.826715, -122.422795)),
- createExampleInterpolator(new FastOutSlowInInterpolator(), 2500));
- return animatorSet;
- case R.id.menu_action_bounce_interpolator:
- AnimatorSet bounceAnimatorSet = new AnimatorSet();
- bounceAnimatorSet.playTogether(
- createLatLngAnimator(START_LAT_LNG, new LatLng(37.787947, -122.407432)),
- createExampleInterpolator(new BounceInterpolator(), 3750)
- );
- return bounceAnimatorSet;
- case R.id.menu_action_anticipate_overshoot_interpolator:
- return createExampleInterpolator(new AnticipateOvershootInterpolator(), 2500);
- case R.id.menu_action_path_interpolator:
- return createExampleInterpolator(PathInterpolatorCompat.create(.22f, .68f, 0, 1.71f), 2500);
+ private final Map<Integer, AnimatorBuilder> ANIMATORS = new HashMap<Integer, AnimatorBuilder>() {
+ {
+ put(R.id.menu_action_accelerate_decelerate_interpolator, new AnimatorBuilder() {
+ @Override
+ public Animator build() {
+ AnimatorSet animatorSet = new AnimatorSet();
+ animatorSet.playTogether(
+ createLatLngAnimator(START_LAT_LNG, new LatLng(37.826715, -122.422795)),
+ createExampleInterpolator(new FastOutSlowInInterpolator(), 2500));
+ return animatorSet;
+ }
+ });
+ put(R.id.menu_action_bounce_interpolator, new AnimatorBuilder() {
+ @Override
+ public Animator build() {
+ AnimatorSet bounceAnimatorSet = new AnimatorSet();
+ bounceAnimatorSet.playTogether(
+ createLatLngAnimator(START_LAT_LNG, new LatLng(37.787947, -122.407432)),
+ createExampleInterpolator(new BounceInterpolator(), 3750)
+ );
+ return bounceAnimatorSet;
+ }
+ });
+ put(R.id.menu_action_anticipate_overshoot_interpolator, new AnimatorBuilder() {
+ @Override
+ public Animator build() {
+ return createExampleInterpolator(new AnticipateOvershootInterpolator(), 2500);
+ }
+ });
+ put(R.id.menu_action_path_interpolator, new AnimatorBuilder() {
+ @Override
+ public Animator build() {
+ return createExampleInterpolator(PathInterpolatorCompat.create(.22f, .68f, 0, 1.71f), 2500);
+ }
+ });
}
- return null;
+ };
+
+ interface AnimatorBuilder {
+ Animator build();
+ }
+
+ private Animator createExamepleInterpolator(int menuItemId) {
+ return ANIMATORS.get(menuItemId).build();
}
private Animator createExampleInterpolator(Interpolator interpolator, long duration) {
What do you think @tobrun?
tobrun
force-pushed
the
tvn-interpolator-example
branch
from
50d781a to
1c5969b
Compare
Member
Author
|
@Guardiola31337 neat, has been adapted, additionally changed target branch to release-agua. |
Guardiola31337
approved these changes
Oct 10, 2017
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
One minor detail.
These examples are awesome 🚀
Contributor
There was a problem hiding this comment.
One minor thing, what about changing the name of the method here to obtainExampleAnimator(int menuItemId) instead? We're not actually creating the animators here and there's another method with the same exact name (createExampleInterpolator(Interpolator interpolator, long duration)) which makes it kinda confusing.
tobrun
force-pushed
the
tvn-interpolator-example
branch
from
1c5969b to
43e1ba3
Compare
20 tasks
20 tasks
This was referenced Nov 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a couple of examples around using animators and interpolators.
cc @mapbox/android