Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Cherry pick #10107: Map::cameraForGeometry()#10166

Merged
asheemmamoowala merged 2 commits into
release-aguafrom
cherry-pick-9809
Oct 9, 2017
Merged

Cherry pick #10107: Map::cameraForGeometry()#10166
asheemmamoowala merged 2 commits into
release-aguafrom
cherry-pick-9809

Conversation

@asheemmamoowala
Copy link
Copy Markdown
Contributor

Cherry pick changes from #10107 for #9809

Comment thread platform/ios/src/MGLMapView.h Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the direction is measured in degrees please use CLLocationDirection instead of double.

Comment thread platform/macos/src/MGLMapView.h Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as on iOS. If the direction is measured in degrees please use CLLocationDirection instead of double.

…. On macOS, also added -[MGLMapView setCamera: withDuration: animationTimingFunction: edgePadding: completionHandler:] for parity with iOS
Copy link
Copy Markdown
Contributor

@fabian-guerra fabian-guerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. 👍🏼

@asheemmamoowala asheemmamoowala merged commit 24bd336 into release-agua Oct 9, 2017
@kkaefer kkaefer added the Core The cross-platform C++ core, aka mbgl label Oct 11, 2017
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 19, 2017
20 tasks
@jfirebaugh jfirebaugh deleted the cherry-pick-9809 branch October 24, 2017 20:40
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 26, 2017
20 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Core The cross-platform C++ core, aka mbgl

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants