This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Asynchronous TextureView#10334
Merged
Merged
Conversation
Contributor
Author
13d223d to
f7c6126
Compare
Member
Capturing chat, moving forward:
|
9cad532 to
8edbf18
Compare
Contributor
Author
|
@tobrun Tested this on the devices I have (Pixel and Galaxy Nexus). Needs a more thorough review/test, but otherwise good to go. |
fed4acb to
b974b9b
Compare
tobrun
approved these changes
Nov 1, 2017
Member
tobrun
left a comment
There was a problem hiding this comment.
Looking great, the new abstraction is really clean. Tested on 3 devices without an issue. Will be running additional tests later when cherry-picked to the release branch.
Member
|
🎉 I still see a couple of "deprecated" messages in the comments, could we remove those before merging? |
…rer subclass - preparation for re-introduction of texture view
b974b9b to
252efca
Compare
Contributor
Author
Sorry, think I got them all now @zugaldia |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings back the (deprecated)
TextureViewoption, removed in #9576. Built on top of the a-synchronous rendering with a dedicated render thread to unblock the main thread as much as possible.TODO: