Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Updrade to gradle 4.1#10402

Closed
tobrun wants to merge 9 commits into
masterfrom
tvn-gradle-4.1
Closed

Updrade to gradle 4.1#10402
tobrun wants to merge 9 commits into
masterfrom
tvn-gradle-4.1

Conversation

@tobrun
Copy link
Copy Markdown
Member

@tobrun tobrun commented Nov 7, 2017

This PR updates the Android project on master to gradle 4.1

  • cherry pick [android] Reorganize dependencies #10268 to master
  • update gradle wrapper to 4.1
  • update android tools to 3.0.0
  • update build tools to 26.0.2 (required for above)
  • enable java 8 language features
  • replaced anonymous inner classes with lambda
    • required cleanup of imports (project wide organize imports)

closes #9364

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Nov 7, 2017
@tobrun tobrun added this to the android-v6.0.0 milestone Nov 7, 2017
@tobrun tobrun self-assigned this Nov 7, 2017
@tobrun
Copy link
Copy Markdown
Member Author

tobrun commented Nov 7, 2017

To make this PR pass we need to update our CI images

Copy link
Copy Markdown
Contributor

@osana osana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Tested that the changes run on my phone.

@zugaldia
Copy link
Copy Markdown
Member

This is amazing, love how the code looks like with the lambda version.

@tobrun
Copy link
Copy Markdown
Member Author

tobrun commented Nov 23, 2017

Since creating this PR, release branch was merged back to master.
Going to create a new PR to do the migration.

@tobrun tobrun closed this Nov 23, 2017
@tobrun tobrun deleted the tvn-gradle-4.1 branch November 23, 2017 08:47
@tobrun tobrun mentioned this pull request Nov 23, 2017
@LukasPaczos LukasPaczos mentioned this pull request Jan 22, 2018
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Android Mapbox Maps SDK for Android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android Studio 3.0 breaking changes

4 participants