[ios, macos] Fix an issue that triggers didSelectAnnotations

[fabian-guerra]

Fixes #10523

[friedbunny]

@fabian-guerra Could you explain why this change is necessary and how it’s fixing the issue? 🙇

[fabian-guerra]

@friedbunny in #9984 we added select/deselect support to shape annotations. Later in #10262 we made shape annotations part of the iterable annotations. The problem is since all annotations are a subclass of MGLShape it was bypassing the filtering for image based annotations. Instead of filtering the annotation using the following code:

mapbox-gl-native/platform/ios/src/MGLMapView.mm

Line 4062 in a344713

annotationRect = [self frameOfImage:annotationImage.image ?: fallbackImage centeredAtCoordinate:annotation.coordinate];

It was falling into:

mapbox-gl-native/platform/ios/src/MGLMapView.mm

Line 4048 in bcfe51c

if ([annotation isKindOfClass:[MGLShape class]])

I added this code to avoid filtering shape annotations. Since are filtered here:

mapbox-gl-native/platform/ios/src/MGLMapView.mm

Lines 4154 to 4160 in a344713

	- (std::vector<MGLAnnotationTag>)shapeAnnotationTagsInRect:(CGRect)rect
	{
	return _rendererFrontend->getRenderer()->queryShapeAnnotations({
	{ CGRectGetMinX(rect), CGRectGetMinY(rect) },
	{ CGRectGetMaxX(rect), CGRectGetMaxY(rect) },
	});
	}

Image based annotations avoided getting filtered by using the image CGRect thus triggering the didSelectAnnotation method. The fix uses MGLMultiPoint to verify for shape annotations.

[fabian-guerra]

@friedbunny I added more context. Please let me know if something is still not clear.

[friedbunny]

Thanks for the explanation. ❤️