Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2834,8 +2834,8 @@ public static Expression floor(Number number) {
* CircleLayer circleLayer = new CircleLayer("layer-id", "source-id");
* circleLayer.setProperties(
* circleColor(switchCase(
eq(literal("it"), resolvedLocale(collator(true, true, "it"))), literal(ColorUtils.colorToRgbaString(Color.GREEN)),
literal(ColorUtils.colorToRgbaString(Color.RED))))
* eq(literal("it"), resolvedLocale(collator(true, true, "it"))), literal(ColorUtils.colorToRgbaString(Color.GREEN)),
* literal(ColorUtils.colorToRgbaString(Color.RED))))
* );
* }
* </pre>
Expand Down Expand Up @@ -3921,13 +3921,10 @@ public String toString() {

// special case for handling unusual input like 'rgba(r, g, b, a)'
if (literalValue instanceof String) {
if (((String) literalValue).contains(",")) {
builder.append("\"").append(literalValue).append("\"");
continue;
}
builder.append("\"").append(literalValue).append("\"");
} else {
builder.append(literalValue);
}

builder.append(literalValue);
} else {
builder.append(argument.toString());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1101,7 +1101,7 @@ public void testCubicBezierExpressionLiteral() throws Exception {

@Test
public void testExpressionConcatToString() throws Exception {
String expected = "[\"concat\", foo, bar]";
String expected = "[\"concat\", \"foo\", \"bar\"]";
String actual = concat(literal("foo"), literal("bar")).toString();
assertEquals("toString should match", expected, actual);
}
Expand All @@ -1116,7 +1116,7 @@ public void testExpressionMinToString() throws Exception {
@Test
public void testExpressionExponentialToString() throws Exception {
String expected = "[\"interpolate\", [\"cubic-bezier\", 1.0, 1.0, 1.0, 1.0],"
+ " [\"get\", x], 0.0, 100.0, 100.0, 200.0]";
+ " [\"get\", \"x\"], 0.0, 100.0, 100.0, 200.0]";
String actual = interpolate(cubicBezier(literal(1), literal(1), literal(1), literal(1)),
get(literal("x")), literal(0), literal(100), literal(100), literal(200)).toString();
assertEquals("toString should match", expected, actual);
Expand Down Expand Up @@ -1367,4 +1367,11 @@ public void testStringNestedCollator() {
String actual = collator(literal(false), eq(literal(2), literal(1)), literal("it")).toString();
assertEquals("expression should match", expected, actual);
}

@Test
public void testStringReverseConversion() {
String expected = "[\"to-string\", [\"get\", \"name_en\"]]";
String actual = Expression.toString(get("name_en")).toString();
assertEquals("Reverse string conversion should match", expected, actual);
}
}