shape annotations

[incanus]

Runtime shape annotations.

• C++ API for adding single shape
• C++ API for adding multiples at once
• Runtime styling at annotation create time
• Exposes StyleProperties et al. to Map users
• C++ API for reordering
• C++ API for removing
• Cocoa API (including selecting only points)
• Remove perf penalty when adding points and shapes at same time, since two invalidations occur
• Track shapes across style changes (Switching styles turns annotations invisible #1488)
• Bring in GeoJSONVT poly simplification - we could get away with punting for a bit here in exchange for performance were it not for problems rendering shapes that span tiles. I do feel good about the state of where I left the GeoJSONVT work and could probably pretty quickly get it into shape to farm out the tiling of shape features instead of the current stopgap naive tiling based on it.
• Polygons with cutout holes
• Shapes around antemeridian?
• Cocoa API docs (currently blocking tests)

Problems/checkpoints:

• Adding shape annotations before style is finished loading misses rendering them. This is because MapContext::updateAnnotationTiles() returns early. This doesn't affect points as their styling is all wrapped up in the style parsing step (since the variable parts are covered in the runtime {sprite} property), the conclusion of which performs a render. Worked around right now with a hack to add after a delay upon startup.
• Threading sanity check.
• General sanity check. This has been messy work.

map.addPointAnnotation(mbgl::LatLng(45, -120), "default_marker");

mbgl::FillProperties fillProperties;
fillProperties.fill_color = mbgl::Color({{ 1, 0, 0, 1 }});
fillProperties.stroke_color = mbgl::Color({{ 0, 0, 0, 1 }});
fillProperties.opacity = 0.25;

mbgl::StyleProperties shapeProperties;
shapeProperties.set<mbgl::FillProperties>(fillProperties);

map.addShapeAnnotation({
    mbgl::LatLng(44, -122),
    mbgl::LatLng(46, -122),
    mbgl::LatLng(46, -121),
    mbgl::LatLng(44, -122)
}, shapeProperties);

[1ec5]

Remember to pull these changes out before merging.

[incanus]

👍

[incanus]

fe2d84c

[incanus]

Things feel good for some real-world data, too:

[incanus]

Bring in GeoJSONVT poly simplification - we could get away with punting for a bit here in exchange for performance were it not for problems rendering shapes that span tiles. I do feel good about the state of where I left the GeoJSONVT work and could probably pretty quickly get it into shape to farm out the tiling of shape features instead of the current stopgap naive tiling based on it.

This should actually be pretty easily fixed. In shape adds, I'm just overflowing the tile extent and assuming all shapes belong in only one tile, as a naive extension of the point add. That's why this happens:

Fixing that up now as a staged approach, so that we don't necessarily need the GeoJSONVT simplification stuff in the first cut. This is a ~2,500 point polyline and it performs well now.

[incanus]

Taking a break from feature clipping, which is a bit of going in circles. I may just punt and bring in the GeoJSONVT work which takes care of this now instead of later, bringing along simplification for the ride. My reluctance to do so there is a bottleneck around the GeoJSONVT object vending tiles to to the annotation manager — maybe not a valid concern.

In the break I am going to rough out the Cocoa adding/removing/styling API since that part won't change and we are successfully using the direct C++ one right now.

[incanus]

BTW current impact of bad feature clipping is:

• Lines: small gaps at tile borders.

  

• Polys: disappear.

  

  

[kkaefer]

prints to the console in Release mode?

[incanus]

a6da538 & mapbox/geojson-vt-cpp@18ef168

[incanus]

Split GeoJSONVT out to https://github.com/mapbox/geojson-vt-cpp. Currently just dupe-copied here still; no formal build or dep process.

[1ec5]

This is kind of a sneaky way of getting access to these methods. The declarations should go in a private header in platform/ios/.

[incanus]

e45bacf

[incanus]

• Squash commit just happened in master with bd0bf29.
• C++ API for reordering: add shape annotation reordering API #1728
• Polygons with cutout holes / interior rings: add support for multipolygons and polygon interior holes #1729
• Perf, annotations disappearing, and antemeridian issues from original ticket in shape annotations #1655 (comment) are all tracked in existing tickets.