[android] Add a method to make map snapshots#4516
Conversation
|
@vkurchatkin this is really awesome, will review soon! |
I haven't reviewed the code or compiled the PR, but here already some feedback: This would improve our parity with Google so having that in MapboxMap would make more sense.
Google maps supports 2 methods for taking a snapshot:
Ideally we also support both where the latter can reuse bitmaps for performance reasons.
Hit me up with any questions you have on this. Related to this feature, it will be hard to write proper unit tests for this but we should be able to come up with some integration/ui tests. |
Somehow missed it, makes sense |
|
I'm going to pull this in to our repo to run the CI tests, this will also allow me to rebase the commits. Update you can follow in #4564 |
|
@tobrun Thanks! |
Fixes: #3466
/cc @tobrun
TODO list:
MapboxMapinstead;