[ios] Adds the ability to get selection events for shape annotations#5502
[ios] Adds the ability to get selection events for shape annotations#5502csmulhern wants to merge 2 commits into
Conversation
# Conflicts: # src/mbgl/annotation/annotation_manager.cpp
33ce483 to
ad0d7a8
Compare
ad0d7a8 to
e1d273e
Compare
|
Thank you for this PR – this is absolutely important functionality to have. I think we’ll ultimately want to combine your SDK-level changes with #5165, which avoids having to pull in |
| void removeAnnotation(AnnotationID); | ||
|
|
||
| AnnotationIDs getPointAnnotationsInBounds(const LatLngBounds&); | ||
| AnnotationIDs getShapeAnnotationsInBounds(const LatLngBounds&); |
There was a problem hiding this comment.
#5165 landed, so now we can implement a queryShapeAnnotations() that calls queryRenderedFeatures() – no custom querying logic is needed anymore. Unlike in queryPointAnnotations(), the call to queryRenderedFeatures() will need to pass in the layer IDs of all the shape annotation layers.
|
This was implemented in #9984 with the approach described in #5502 (comment). Thank you for this early iteration, though! |
This should not break any existing behavior, as the implementation makes shapes default to
enabled = NO.