Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Adds the ability to get selection events for shape annotations#5502

Closed
csmulhern wants to merge 2 commits into
mapbox:masterfrom
calendreco:shape-annotations
Closed

[ios] Adds the ability to get selection events for shape annotations#5502
csmulhern wants to merge 2 commits into
mapbox:masterfrom
calendreco:shape-annotations

Conversation

@csmulhern
Copy link
Copy Markdown

This should not break any existing behavior, as the implementation makes shapes default to enabled = NO.

# Conflicts:
#	src/mbgl/annotation/annotation_manager.cpp
@csmulhern csmulhern force-pushed the shape-annotations branch from 33ce483 to ad0d7a8 Compare June 28, 2016 20:57
@csmulhern csmulhern force-pushed the shape-annotations branch from ad0d7a8 to e1d273e Compare June 28, 2016 21:03
@1ec5
Copy link
Copy Markdown
Contributor

1ec5 commented Jun 28, 2016

Thank you for this PR – this is absolutely important functionality to have. I think we’ll ultimately want to combine your SDK-level changes with #5165, which avoids having to pull in boost::geometry. (With #5110 and #352, we finally have a feature index that can be used for everything, not just points and not just annotations.) I’m currently focusing on the 3.3.0 release right now, but I’ll pick up #5165 again right afterwards so we can get rid of the existing mbgl code that’s limited to points.

/cc @jfirebaugh @boundsj @tobrun

@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS annotations Annotations on iOS and macOS or markers on Android labels Jun 28, 2016
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Jun 28, 2016
@boundsj boundsj modified the milestones: ios-future, ios-v3.4.0 Aug 22, 2016
Comment thread include/mbgl/map/map.hpp
void removeAnnotation(AnnotationID);

AnnotationIDs getPointAnnotationsInBounds(const LatLngBounds&);
AnnotationIDs getShapeAnnotationsInBounds(const LatLngBounds&);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5165 landed, so now we can implement a queryShapeAnnotations() that calls queryRenderedFeatures() – no custom querying logic is needed anymore. Unlike in queryPointAnnotations(), the call to queryRenderedFeatures() will need to pass in the layer IDs of all the shape annotation layers.

@1ec5
Copy link
Copy Markdown
Contributor

1ec5 commented Dec 20, 2017

This was implemented in #9984 with the approach described in #5502 (comment). Thank you for this early iteration, though!

@1ec5 1ec5 closed this Dec 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

annotations Annotations on iOS and macOS or markers on Android feature iOS Mapbox Maps SDK for iOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants