This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[android] Update GLSL + ensure binding to OpenGL ES 2.0#7044
Merged
Conversation
|
@brunoabinader, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ljbade, @jfirebaugh and @mourner to be potential reviewers. |
cammace
approved these changes
Nov 14, 2016
Contributor
cammace
left a comment
There was a problem hiding this comment.
Maps look to be working in emulator now. LGTM
This was referenced Nov 14, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @masterjefferson logcat, we've found the root cause for the crashes using Android emulator Hardware OpenGL ES 2.0 support - in particular:
This means that the shader compiler was already defining those macros for non-GLSL ES shader code. I have a PR in mapbox/mapbox-gl-shaders#36 that checks if those macros are already defined, and also ensure NativeMapView that we're binding to the EGL's OpenGL ES 2.0 API.
Fixes the issues mentioned in #2995 and #6400.
/cc @kkaefer @mapbox/android