Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

[android] Update GLSL + ensure binding to OpenGL ES 2.0#7044

Merged
brunoabinader merged 1 commit into
masterfrom
android-emulator-hw-gpu
Nov 14, 2016
Merged

[android] Update GLSL + ensure binding to OpenGL ES 2.0#7044
brunoabinader merged 1 commit into
masterfrom
android-emulator-hw-gpu

Conversation

@brunoabinader
Copy link
Copy Markdown
Contributor

@brunoabinader brunoabinader commented Nov 14, 2016

Thanks to @masterjefferson logcat, we've found the root cause for the crashes using Android emulator Hardware OpenGL ES 2.0 support - in particular:

ERROR: 0:6: error(#101) Macro redefined: lowp
ERROR: 0:7: error(#101) Macro redefined: mediump
ERROR: 0:8: error(#101) Macro redefined: highp

This means that the shader compiler was already defining those macros for non-GLSL ES shader code. I have a PR in mapbox/mapbox-gl-shaders#36 that checks if those macros are already defined, and also ensure NativeMapView that we're binding to the EGL's OpenGL ES 2.0 API.

Fixes the issues mentioned in #2995 and #6400.

/cc @kkaefer @mapbox/android

@mention-bot
Copy link
Copy Markdown

@brunoabinader, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ljbade, @jfirebaugh and @mourner to be potential reviewers.

@brunoabinader brunoabinader added Android Mapbox Maps SDK for Android bug tests labels Nov 14, 2016
Copy link
Copy Markdown
Contributor

@cammace cammace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maps look to be working in emulator now. LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Android Mapbox Maps SDK for Android bug tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants