This repository was archived by the owner on Aug 8, 2023. It is now read-only.
WIP GLSurfaceView#8031
Closed
tobrun wants to merge 6 commits into
Closed
Conversation
|
@tobrun, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @zugaldia and @1ec5 to be potential reviewers. |
jfirebaugh
reviewed
Feb 13, 2017
| * <p> | ||
| * The {@link com.mapbox.mapboxsdk.maps.MapboxMap.MarkerViewAdapter#onDeselect(MarkerView, View)} | ||
| * will be called to execute an animation. | ||
| * will be called to executeOnRenderThread an animation. |
Contributor
There was a problem hiding this comment.
Looks like a search-and-replace made some unintended changes.
Contributor
Tracking this refactoring in #8175, in case there’s an opportunity to implement it separately ahead of this PR. |
Contributor
|
Closing in light of #8820 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP PR that covers migration to GLSurfaceView.
Todo:
cc @ivovandongen @mapbox/android