This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Use AAssetManager instead of bundling libzip#8712
Merged
Merged
Conversation
Member
Author
|
New: Old: so we got ~30-50 KB of savings for standard archs. |
ivovandongen
approved these changes
Apr 13, 2017
| private: | ||
| jni::UniqueObject<android::AssetManager> assetManager; | ||
| class Impl; | ||
| std::unique_ptr<util::Thread<Impl>> thread; |
Contributor
There was a problem hiding this comment.
We don't want to use the thread pool?
Member
Author
There was a problem hiding this comment.
We do, but I've modeled this FileSource after all the other FileSources, and they are still using util::Thread. I attempted to port them to the actor system in #7678
tobrun
approved these changes
Apr 13, 2017
c71bbaa to
2573529
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Android NDK exposes
AAssetManager, which is a way to access theAssetManager, which is a way to access resources from the zipfile (among other things).Implementing this would allow us to get rid of bundling libzip, and at the same time change the meaning of "asset" to be the Android definition of "asset".