This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[core] Reset observers of removed Sources and Layers#8900
Merged
Conversation
This ensures that the observer is not an invalid reference if the removed Source/Layer is retained, but the Style is deallocated.
jfirebaugh
force-pushed
the
reset-observer-on-remove
branch
from
088ed36 to
413c5eb
Compare
kkaefer
approved these changes
May 5, 2017
This was referenced May 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that the observer is not an invalid reference if the removed Source/Layer is retained, but the Style is deallocated.
This would have caused memory corruption in the following sequence:
GeoJSONSource::setURL,Layer::setFilter, or any other setter)