Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Rewire gesture handling and telemetry event push#9494

Merged
tobrun merged 1 commit into
masterfrom
tvn-gestures-cherry-pick
Jul 17, 2017
Merged

Rewire gesture handling and telemetry event push#9494
tobrun merged 1 commit into
masterfrom
tvn-gestures-cherry-pick

Conversation

@tobrun
Copy link
Copy Markdown
Member

@tobrun tobrun commented Jul 13, 2017 •
edited
Loading

This PR:

  • fixes dragging while zooming issue, closes Since 5.1.0 : Zoom + Dragging not working #9413
  • simplifies state handling in our gesture code
  • moves telemetry event pushes to the correct place in code where the gesture is valid.
  • does not solve the problems of the almeros library
  • does not prohibit scale and rotate to execute at the same time

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jul 13, 2017
@tobrun tobrun added this to the android-v5.2.0 milestone Jul 13, 2017
@tobrun tobrun self-assigned this Jul 13, 2017
@tobrun tobrun force-pushed the tvn-gestures-cherry-pick branch from 75271a7 to 7a1fc73 Compare July 14, 2017 08:31
Guardiola31337
Guardiola31337 approved these changes Jul 17, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tobrun tobrun merged commit 3c6a6c5 into master Jul 17, 2017
@tobrun tobrun deleted the tvn-gestures-cherry-pick branch July 17, 2017 07:12
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 6, 2017
Closed
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 19, 2017
Closed
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 26, 2017
Closed
20 tasks
@tobrun tobrun mentioned this pull request Nov 3, 2017
Closed
21 tasks
This was referenced Nov 14, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zugaldia zugaldia Awaiting requested review from zugaldia

1 more reviewer

@Guardiola31337 Guardiola31337 Guardiola31337 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tobrun tobrun

Labels

Android Mapbox Maps SDK for Android

Projects

None yet

Milestone

android-v5.2.0

Development

Successfully merging this pull request may close these issues.

Since 5.1.0 : Zoom + Dragging not working

3 participants

@tobrun @Guardiola31337 @lilykaiser